fix: update minimum PHP version check in bootstrap to 8.3#40686
fix: update minimum PHP version check in bootstrap to 8.3#40686lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com. |
Description
Update the PHP version check in
app/bootstrap.phpto match the actual minimum PHP requirement.Problem
The bootstrap file checks for
PHP_VERSION_ID < 80100(PHP 8.1.0) and displays an error message referencing PHP 8.1.0. However,composer.jsonrequires~8.3.0||~8.4.0||~8.5.0, making PHP 8.1 and 8.2 unsupported.A user running PHP 8.1 or 8.2 would pass the bootstrap check but fail at Composer dependency resolution, leading to a confusing error instead of the clear bootstrap message.
Solution
Update the check to
PHP_VERSION_ID < 80300and the error message to reference "PHP 8.3.0", aligning with the actualcomposer.jsonrequirement.Files Changed
app/bootstrap.php⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz