Add VED currency and remove obsolete VEF for Venezuela (GH-40698)#40740
Open
mohaelmrabet wants to merge 2 commits intomagento:2.4-developfrom
Open
Add VED currency and remove obsolete VEF for Venezuela (GH-40698)#40740mohaelmrabet wants to merge 2 commits intomagento:2.4-developfrom
mohaelmrabet wants to merge 2 commits intomagento:2.4-developfrom
Conversation
- Replace VEF (Venezuelan Bolívar Fuerte, obsolete since Aug 2018) with VED (Venezuelan Bolívar Digital, current ISO 4217 code since Oct 2021) - Update VEB comment to clarify it is a pre-2008 historical currency - Also add XCG (Caribbean Guilder) and NIO (Nicaraguan Córdoba) that were present in Config.php but missing from the ConfigTest fixture array - All unit tests pass (6 tests, 27 assertions) Fixes: magento#40698
|
Hi @mohaelmrabet. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
Contributor
Author
|
@magento run all tests |
1 similar comment
Contributor
Author
|
@magento run all tests |
|
Failed to run the builds. Please try to re-run them later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Venezuela has undergone multiple currency redenominations. Magento currently
includes
VEF(Bolívar Fuerte), which has not been legal tender sinceAugust 20, 2018, while the current official currency
VED(Bolívar Digital,ISO 4217, in effect since October 1, 2021) is entirely absent.
This causes silent failures: exchange rate lookups return
0when therequested currency code does not exist in Magento's allowed list, breaking
shipping carrier and payment gateway integrations for Venezuelan merchants.
Changes:
VEF(Bolívar Fuerte, obsolete since Aug 2018) withVED(Bolívar Digital, current ISO 4217 code since Oct 2021) in
lib/internal/Magento/Framework/Locale/Config.phpVEBcomment to clarify it is a pre-2008 historical currencyConfigTest.phpfixture withConfig.php(also addsXCGandNIOthat were present inConfig.phpbut missing from the test array)Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
"Allowed Currencies" multiselect
VEDas the store base currency and save — no error should occurVEDand verify the rate is fetched correctly (not
0)Questions or comments
VEB(pre-2008 Bolívar) has been kept for historical/backward compatibilityas it was already present and the issue did not request its removal.
Happy to remove it in a follow-up or in this PR if preferred.
Contribution checklist (*)