Skip to content

Add VED currency and remove obsolete VEF for Venezuela (GH-40698)#40740

Open
mohaelmrabet wants to merge 2 commits intomagento:2.4-developfrom
mohaelmrabet:feature/add-ved-currency-gh-40698
Open

Add VED currency and remove obsolete VEF for Venezuela (GH-40698)#40740
mohaelmrabet wants to merge 2 commits intomagento:2.4-developfrom
mohaelmrabet:feature/add-ved-currency-gh-40698

Conversation

@mohaelmrabet
Copy link
Copy Markdown
Contributor

Description (*)

Venezuela has undergone multiple currency redenominations. Magento currently
includes VEF (Bolívar Fuerte), which has not been legal tender since
August 20, 2018, while the current official currency VED (Bolívar Digital,
ISO 4217, in effect since October 1, 2021) is entirely absent.

This causes silent failures: exchange rate lookups return 0 when the
requested currency code does not exist in Magento's allowed list, breaking
shipping carrier and payment gateway integrations for Venezuelan merchants.

Changes:

  • Replace VEF (Bolívar Fuerte, obsolete since Aug 2018) with VED
    (Bolívar Digital, current ISO 4217 code since Oct 2021) in
    lib/internal/Magento/Framework/Locale/Config.php
  • Update VEB comment to clarify it is a pre-2008 historical currency
  • Sync ConfigTest.php fixture with Config.php (also adds XCG and
    NIO that were present in Config.php but missing from the test array)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Add VED (Venezuelan Bolívar Digital) and remove obsolete VEF/VES currency codes #40698

Manual testing scenarios (*)

  1. Go to Stores → Configuration → General → Currency Setup
  2. Verify that Venezuelan Bolívar Digital (VED) appears in the
    "Allowed Currencies" multiselect
  3. Verify that VEF no longer appears in the list
  4. Select VED as the store base currency and save — no error should occur
  5. Go to Stores → Currency → Currency Rates, import rates for VED
    and verify the rate is fetched correctly (not 0)

Questions or comments

VEB (pre-2008 Bolívar) has been kept for historical/backward compatibility
as it was already present and the issue did not request its removal.
Happy to remove it in a follow-up or in this PR if preferred.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

- Replace VEF (Venezuelan Bolívar Fuerte, obsolete since Aug 2018) with
  VED (Venezuelan Bolívar Digital, current ISO 4217 code since Oct 2021)
- Update VEB comment to clarify it is a pre-2008 historical currency
- Also add XCG (Caribbean Guilder) and NIO (Nicaraguan Córdoba) that were
  present in Config.php but missing from the ConfigTest fixture array
- All unit tests pass (6 tests, 27 assertions)

Fixes: magento#40698
@m2-assistant
Copy link
Copy Markdown

m2-assistant bot commented Apr 15, 2026

Hi @mohaelmrabet. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@mohaelmrabet
Copy link
Copy Markdown
Contributor Author

@magento run all tests

@mohaelmrabet
Copy link
Copy Markdown
Contributor Author

@magento run all tests

1 similar comment
@mohaelmrabet
Copy link
Copy Markdown
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link
Copy Markdown

Failed to run the builds. Please try to re-run them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add VED (Venezuelan Bolívar Digital) and remove obsolete VEF/VES currency codes

1 participant