Shortcut Guide V2 by noraa-junker · Pull Request #40834 · microsoft/PowerToys

noraa-junker · 2025-07-27T12:48:22Z

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Work for future PRs:

Localization of built-in shortcut files
Further customization (we can wait on user feedback for that)
Reimplement holding windows key
Search bar

Images

Recording.2025-10-27.211717.mp4

Validation Steps Performed

…eMethods.cs

…change

… CPPProject

…t/PowerToys into feature/shortcutguidev2

noraa-junker · 2026-04-20T11:30:18Z

@copilot Add a dropdown menu to the Settings with which you can select if the Shortcut Guide window should appear on the left or the right side of the screen. Implement this dropdown and change the positioning logic of the Shortcut Guide window.

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/3883a5cc-f63f-4d66-8d5f-a73a94b9d86a Co-authored-by: noraa-junker <58633848+noraa-junker@users.noreply.github.com>

Copilot · 2026-04-20T11:38:51Z

@copilot Add a dropdown menu to the Settings with which you can select if the Shortcut Guide window should appear on the left or the right side of the screen. Implement this dropdown and change the po...

Done in commit 43b37bc7. Here's what was added:

ShortcutGuideProperties: New window_position setting (default: "left")
ShortcutGuideViewModel: New PositionIndex property (0 = Left, 1 = Right)
ShortcutGuidePage.xaml: New "Window position" SettingsCard with Left/Right ComboBox in the Appearance & behavior group
MainWindow.xaml.cs: SetWindowPosition() now checks the setting — Left places the window at monitorRect.X, Right places it at the opposite edge (monitorRect.X + monitorRect.Width − windowWidth)

The setting takes effect the next time Shortcut Guide is launched (same as the Theme setting).

noraa-junker · 2026-04-20T11:50:49Z

@copilot Fix the spelling check by adding these words into the exclusion file

Unrecognized words (10)

Datasheet
gridlines
msaccess
mspub
powerpnt
Scrollback
ungroup
visio
winproj
winword

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/9b871785-a2b4-4e2b-8fc0-d19b49fb0792 Co-authored-by: noraa-junker <58633848+noraa-junker@users.noreply.github.com>

niels9001 · 2026-04-20T11:53:40Z

            <controls:PageLink x:Uid="LearnMore_ShortcutGuide" Link="https://aka.ms/PowerToysOverview_ShortcutGuide" />
        </controls:SettingsPageControl.PrimaryLinks>
+        <controls:SettingsPageControl.SecondaryLinks>
+            <controls:PageLink Link="https://noraajunker.ch" Text="Noraa Junker's work on Shortcut Guide V2" />


Needs to be locced

These aren't loced for any module.

Copilot · 2026-04-20T11:53:41Z

@copilot Fix the spelling check by adding these words into the exclusion file

Unrecognized words (10)
...

Done in commit 0a20b7ef. All 10 words have been added to .github/actions/spell-check/expect.txt:

Datasheet, gridlines, msaccess, mspub, powerpnt, Scrollback, ungroup, visio, winproj, winword

niels9001 · 2026-04-20T11:54:16Z

-                    <tkcontrols:SettingsCard
-                        Name="ShortcutGuidePressTimeForGlobalWindowsShortcuts"
-                        x:Uid="ShortcutGuide_PressTimeForGlobalWindowsShortcuts"
-                        HeaderIcon="{ui:FontIcon Glyph=&#xE916;}"
-                        Visibility="{x:Bind ViewModel.UseLegacyPressWinKeyBehavior, Mode=OneWay, Converter={StaticResource BoolToVisibilityConverter}}">
-                        <NumberBox
-                            MinWidth="{StaticResource SettingActionControlMinWidth}"
-                            LargeChange="100"
-                            Minimum="100"
-                            SmallChange="50"
-                            SpinButtonPlacementMode="Compact"
-                            Value="{x:Bind ViewModel.PressTime, Mode=TwoWay}" />


Are we losing the "hold the Windows key for Shortcut Guide to open"?

Yes. I tried implementing it, but it would require a whole different application logic, so I would like to postpone this to later.

noraa-junker · 2026-04-20T12:17:15Z

@copilot Fix expect.txt, remove all duplicate words and sort the file alphabetically. The entries are case-sensitive, so AAA is not the same as aaa

noraa-junker · 2026-04-20T12:29:35Z

@copilot Fix expect.txt, remove all duplicate words and sort the file alphabetically. The entries are case-sensitive, so AAA is not the same as aaa

…le sort (#47112) ## Summary of the Pull Request This updates the spell-check allowlist at `.github/actions/spell-check/expect.txt` to remove duplicate entries and enforce a single alphabetical ordering. Matching remains case-sensitive (e.g., `AAA` and `aaa` are treated as distinct entries). ## PR Checklist - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments - **Scope** - Updated only `.github/actions/spell-check/expect.txt`. - **Changes** - Removed exact duplicate words. - Reordered file into strict alphabetical order. - Preserved case-sensitive distinctions. - **Example** ```bash LC_ALL=C sort -u .github/actions/spell-check/expect.txt -o .github/actions/spell-check/expect.txt ``` ## Validation Steps Performed N/A (no behavioral/code-path changes; list normalization only). Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: noraa-junker <58633848+noraa-junker@users.noreply.github.com>

github-actions · 2026-04-20T12:40:31Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	1

See ❌ Event descriptions for more information.

These words are not needed and should be removed

bck diu DSVG IPREVIEW ITHUMBNAIL kdc LPCFHOOKPROC LUMA MAXDWORD MRT newcolor oldcolor outsourced pinboard rectp scanled suntimes timespan traies udit VSync workerw

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Should be `; otherwise` or `. Otherwise`

https://study.com/learn/lesson/otherwise-in-a-sentence.html

, [Oo]therwise\b

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

noraa-junker added 18 commits October 14, 2024 19:02

[WIP] Shortcut Guide V2

03587ae

Changed style a little bit

7a6189b

Push

c81a423

Push

d5f5500

Code cleanup

22dc870

Fix display on monitor with mouse and move all NaticeMethods to Nativ…

a14c458

…eMethods.cs

Fix error messages and read application titles out of index manifest

da7b789

Rename YmlInterpreter to ManifestInterpreter

6952deb

Merge main

a292a92

push

b16b457

Add support for multiple shortcuts

7ce5182

Add copying keyboard manifests and other improvements

569f072

Add keyboard accelerator to the search box

54d176c

Handle errors displaying app and close window automatically on focus …

0b823ea

…change

Add taskbar indicators

7596e96

Refactoring and localisation

46df486

Remove some hosts references and fix close button

da77396

Refactoring

a6b7614

github-advanced-security AI found potential problems Jul 27, 2025

View reviewed changes

noraa-junker added 6 commits July 27, 2025 16:40

Remove old Shortcut Guide

d73ab4f

Remove legacy shortcut behaviour

07760e4

Fix closing by shortcut add closing by ESC and fix missing files from…

1580279

… CPPProject

Merge main in

ba40989

Merge main in

3e75fb0

Merge branch 'feature/shortcutguidev2' of https://github.com/microsof…

95e0a20

…t/PowerToys into feature/shortcutguidev2

github-advanced-security AI found potential problems Jul 27, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

noraa-junker added 2 commits July 27, 2025 18:00

Merge branch 'feature/shortcutguidev2' of https://github.com/microsof…

e26bf2a

…t/PowerToys into feature/shortcutguidev2

Merge branch 'feature/shortcutguidev2' of https://github.com/microsof…

be799dd

…t/PowerToys into feature/shortcutguidev2

This comment has been minimized.

Sign in to view

Update Resources.resw

019ee04

This comment has been minimized.

Sign in to view

More shortcuts MORE!

c011b22

github-advanced-security AI found potential problems Apr 17, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Copilot started work on behalf of noraa-junker April 20, 2026 11:30 View session

Add window position dropdown (Left/Right) to Shortcut Guide settings

43b37bc

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/3883a5cc-f63f-4d66-8d5f-a73a94b9d86a Co-authored-by: noraa-junker <58633848+noraa-junker@users.noreply.github.com>

Copilot finished work on behalf of noraa-junker April 20, 2026 11:39

Correct postion logic

bf18e78

Copilot started work on behalf of noraa-junker April 20, 2026 11:51 View session

Add spelling exceptions for ShortcutGuide-related words to expect.txt

0a20b7e

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/9b871785-a2b4-4e2b-8fc0-d19b49fb0792 Co-authored-by: noraa-junker <58633848+noraa-junker@users.noreply.github.com>

niels9001 reviewed Apr 20, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Copilot finished work on behalf of noraa-junker April 20, 2026 11:55

Merge branch 'main' into feature/shortcutguidev2

8d4a24c

This comment has been minimized.

Sign in to view

Update expect.txt

406b42d

This comment has been minimized.

Sign in to view

Update expect.txt

03ff496

This comment has been minimized.

Sign in to view

Conversation

noraa-junker commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

noraa-junker commented Apr 20, 2026

Uh oh!

Copilot AI commented Apr 20, 2026

Uh oh!

noraa-junker commented Apr 20, 2026

Uh oh!

niels9001 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

noraa-junker Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 20, 2026

Uh oh!

niels9001 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

noraa-junker Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

noraa-junker commented Apr 20, 2026

Uh oh!

This comment has been minimized.

noraa-junker commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Forbidden patterns 🙅 (1)

Should be ; otherwise or . Otherwise

Uh oh!

Reviewers

Assignees

noraa-junker commented Jul 27, 2025 •

edited

Loading

Should be `; otherwise` or `. Otherwise`