Skip to content

Delete the old environment before setting the status to NEW #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lubaihua33 wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −5
Open

Delete the old environment before setting the status to NEW #4414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c7add7
Delete the old environment before setting the status to NEW
lubaihua33 Apr 13, 2026
2fcd5a2
Apply suggestion from @Copilot
lubaihua33 Apr 16, 2026
6c58a71
Update selftests/runners/test_lisa_runner.py
lubaihua33 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lisa/runners/lisa_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ def _deploy_environment_task(
environment.status = EnvironmentStatus.New
except Exception as e:
if self._need_retry(environment):
# if need retry, the environment should be deleted before setting the
# status to new, otherwise, the environment won't be cleaned up.
self._delete_environment_task(environment=environment, test_results=[])
environment.status = EnvironmentStatus.New
Comment thread
lubaihua33 marked this conversation as resolved.
else:
# Final attempt failed; handle the failure
Expand Down
12 changes: 7 additions & 5 deletions selftests/runners/test_lisa_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,11 +639,13 @@ def test_env_retry_on_deployment_fail(self) -> None:
"generated_2",
],
expected_deployed_envs=[],
expected_deleted_envs=[
"generated_0",
"generated_1",
"generated_2",
],
# Each environment is deleted once per failed deployment attempt:
# the initial attempt plus `env_runbook.retry` retries.
expected_deleted_envs=(
["generated_0"] * (env_runbook.retry + 1)
+ ["generated_1"] * (env_runbook.retry + 1)
+ ["generated_2"] * (env_runbook.retry + 1)
),
runner=runner,
)
self.verify_test_results(
Expand Down
Loading