docs: add missing import os in FAQ.md Python code snippet#28220
Open
lingxiu58 wants to merge 1 commit intomicrosoft:mainfrom
Open
docs: add missing import os in FAQ.md Python code snippet#28220lingxiu58 wants to merge 1 commit intomicrosoft:mainfrom
import os in FAQ.md Python code snippet#28220lingxiu58 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…#28219) The FAQ.md Python example for forcing single-threaded execution used os.environ without importing os, which would raise NameError at runtime. Signed-off-by: Cocoon-Break <86288566+lingxiu58@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a broken Python code example in
docs/FAQ.md.Problem
The FAQ section "How do I force single threaded execution mode in ORT?" contains a Python snippet that calls
os.environ["OMP_NUM_THREADS"] = "1"before importingos. Running this snippet as-is raises:Fix
Added
import oson the line immediately before theos.environcall.Changes
docs/FAQ.md: Insertimport osbeforeos.environ["OMP_NUM_THREADS"] = "1"Closes #28219
Signed-off-by: Cocoon-Break 86288566+lingxiu58@users.noreply.github.com