Upgrade Angular 16 → 19

[chensation]

Angular Version Upgrades (16 -> 17 -> 18 -> 19)

Three incremental upgrade commits, each verified with full unit tests (95/95) and Cypress e2e tests (171/171).

Commit 1: Angular 17

• All @angular/* packages 16.2 -> 17.3
• TypeScript 4.9 -> 5.4, Zone.js 0.13 -> 0.14
• @ng-bootstrap/ng-bootstrap 15 -> 16, @angular-eslint/* 16 -> 17
• Cypress 10 -> 13, @cypress/schematic 2.0 -> 2.5

Commit 2: Angular 18

• All @angular/* packages 17.3 -> 18.2
• @ng-bootstrap/ng-bootstrap 16 -> 17, @angular-eslint/* 17 -> 18, @typescript-eslint/* 5 -> 8

Commit 3: Angular 19

• All @angular/* packages 18.2 -> 19.2
• TypeScript 5.4 -> 5.8, Zone.js 0.14 -> 0.15
• @ng-bootstrap/ng-bootstrap 17 -> 18, @angular-eslint/* 18 -> 19, @types/node 12 -> 18

Commit 4: CI Pipeline Update

• Upgraded actions/checkout from v2 to v4 and actions/setup-node from v1 to v4
• Angular 19 requires Node.js >= 18.19.1; the old action versions failed to install Node 20.x properly

Note on standalone: false (222 files changed)

Angular 19 changed the default for @Component, @Directive, and @Pipe decorators from standalone: false to standalone: true. Since this project uses NgModules, every decorator needed an explicit standalone: false to preserve existing behavior. This was applied automatically by the ng update schematic and accounts for the vast majority of changed files. No architectural change -- the project remains NgModule-based. Migration to standalone components can be done incrementally in a future effort.

Code Coverage

Code coverage report has been broken for a long time, with the new update, it is now blocking pipeline from properly completing. Disabling it for now, a separate work item has been filed for it: #1011

Manual Adjustments

Angular 17:

• Removed deprecated @import '@angular/material/theming' in styles.scss (replaced by existing @use)
• Fixed Cypress 13 breaking changes:
  • cy.within() now requires a single element -- updated selectors
  • Intercept alias indexing changed from 0-based to 1-based
  • Test isolation enabled by default -- added cy.visit() to orchestration view tests
  • cy.contains().should('not.exist') pattern replaced with cy.root().should('not.contain', ...)

Angular 18:

• Fixed NG5002: replaced unsupported two-way binding [(collapsed)]="!copy" with one-way [collapsed]="!copy" in replica-status component

Angular 19:

• Fixed TypeScript 5.8 type error: cast moment to any for vis-timeline MomentConstructor type mismatch
• Replaced deprecated RouterTestingModule with provideRouter() in tests
• Removed unused imports from routes.service.spec.ts
• Fixed route test root path assertion ('' vs '/')
• Fixed XSS test assertion: Angular 19 sanitizer preserves original quote style
• Fixed Sass deprecations: @import -> @use, darken() -> color.adjust()
• Fixed Material theming: positional args -> map format for m2-define-light-theme
• Fixed CSS nested declaration order warning
• Application builder migration skipped: the esbuild application builder breaks Cypress focus event handling. Kept the browser builder. See tree.cy.js for details.

Cypress
Cypress has been upgraded to 15