Cluster insights: lazy-load node details, use row expander, remove expandable-link#1013
Merged
chensation merged 9 commits intomasterfrom Apr 16, 2026
Merged
Conversation
- Defer per-node API calls (getDeployedReplicasByApplication, getDeployedApplications) from page load to row expand, reducing initial requests from 2*N to 0 - Remove system primary replica count column from table (only shown in expanded details) - Add test asserting expanded details show correct replica and app counts
chensation
force-pushed
the
cluster-insights-lazy-load-node-details
branch
from
396b242 to
e11c3db
Compare
- Replace expandable-link with built-in row expander chevron for both nodes and replicas - Reuse display objects across refreshes to preserve expanded state (event-tab pattern) - Remove expandedReplicasState Map tracking from replica-list - Delete unused ExpandableLinkComponent and ListColumnSettingWithExpandableLink - Fix null defaultSortPropertyPaths and type errors
chensation
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Improves Cluster Insights performance and UX by deferring node-detail API calls until a row is expanded, switching nodes/replicas to the built-in row expander, and removing the custom expandable-link component.
Changes:
- Lazy-load per-node details on row expand (removes 2*N calls from initial nodes load)
- Replace expandable-link with built-in row expander for nodes and replicas
- Remove expandable-link component/module wiring and update Cypress coverage for expand behavior
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/SfxWeb/src/app/views/cluster-insights/replica-list/replica-list.component.ts | Switch replicas to row expander + reuse replica display objects across refreshes |
| src/SfxWeb/src/app/views/cluster-insights/nodes/nodes.component.ts | Lazy-load node details on expand + reuse node display objects across refreshes |
| src/SfxWeb/src/app/views/cluster-insights/expandable-link/expandable-link.component.ts | Deleted unused expandable-link component |
| src/SfxWeb/src/app/views/cluster-insights/expandable-link/expandable-link.component.scss | Deleted expandable-link styles |
| src/SfxWeb/src/app/views/cluster-insights/expandable-link/expandable-link.component.html | Deleted expandable-link template |
| src/SfxWeb/src/app/views/cluster-insights/cluster-insights.module.ts | Remove ExpandableLinkComponent from module declarations |
| src/SfxWeb/cypress/e2e/cluster-insights.cy.js | Update e2e to expand via row expander and assert lazy-loaded details |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 7 commits
April 15, 2026 14:44
…w predicate, reset stale fields on reuse
…zy-load-node-details # Conflicts: # src/SfxWeb/cypress/e2e/cluster-insights.cy.js # src/SfxWeb/src/app/views/cluster-insights/expandable-link/expandable-link.component.ts
jeffj6123
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defers per-node API calls from page load to row expand in the cluster insights panel, significantly reducing initial load time for large clusters. Replaces the expandable-link component with the built-in row expander chevron for both nodes and replicas.
Changes
getDeployedReplicasByApplicationandgetDeployedApplicationscalls are now made only when a node row is expanded, reducing initial API requests from 2*N to 0defaultSortPropertyPathsandReplicaRoleindexing type errorsImpact
For a cluster with N nodes, initial page load goes from 2N+1 API calls to just 1. Each expanded node triggers only 2 calls on demand.