fix: persist bitmap index valid bitset for nullable array fields#49008
fix: persist bitmap index valid bitset for nullable array fields#49008sre-ci-robot merged 3 commits intomilvus-io:masterfrom
Conversation
Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
mergify
bot
added
dco-passed
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
| size_t valid_bitset_size = (total_num_rows_ + 7) / 8; | ||
| std::shared_ptr<uint8_t[]> valid_bitset_data( | ||
| new uint8_t[valid_bitset_size]); | ||
| memset(valid_bitset_data.get(), 0, valid_bitset_size); |
There was a problem hiding this comment.
we should be able to directly copy from valid_bitset_.data(), instead of copy bit by bit?
There was a problem hiding this comment.
We can copy directly. But in this way, we assume that the underlying format of TargetBitmap would not change. Otherwise, the format will be corrupt.
There was a problem hiding this comment.
hmm, that is fair. we may migrate to roaring one day
| "bitmap valid_bitset size mismatch, expect {}, got {}", | ||
| expected_size, | ||
| data_size); | ||
| valid_bitset_ = TargetBitmap(total_num_rows_, false); |
There was a problem hiding this comment.
can we memcpy into valid_bitset_?
sre-ci-robot
added
the
low-code-coverage
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #49008 +/- ##
==========================================
- Coverage 77.97% 77.96% -0.01%
==========================================
Files 2167 2167
Lines 356240 356431 +191
==========================================
+ Hits 277783 277909 +126
- Misses 69915 69959 +44
- Partials 8542 8563 +21
🚀 New features to boost your workflow:
|
Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
sre-ci-robot
added
low-code-coverage
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SpadeA-Tang, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ci-rerun-e2e-default |
|
/lgtm |
4 participants
issue: #48901