fix: [3.0] preserve wildcard privilege in RBAC backup/restore#49012
fix: [3.0] preserve wildcard privilege in RBAC backup/restore#49012sre-ci-robot merged 1 commit intomilvus-io:3.0from
Conversation
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
|
/lgtm |
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
|
ci-rerun-build-ut-cov |
- Catalog.RestoreRBAC routed IsAnyWord through the IsPrivilegeNameDefined
/else branches and ended up calling PrivilegeGroupNameForMetastore("*"),
writing 'grantee-id/<id>/PrivilegeGroup*'.
- MetaTable.CheckIfRBACRestorable rejected wildcard grants with
'privilege [*] does not exist' before broadcastRestoreRBACV2 ever
reached the catalog, so the catalog fix alone was unreachable on the
in-process restore path.
issue: milvus-io#48963
Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
(cherry picked from commit b3211b1)
5c2170d to
111b4cd
Compare
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liliu-z, shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
issue: #48963
pr: #48978