Skip to content

fix: [3.0] preserve wildcard privilege in RBAC backup/restore#49012

Merged
sre-ci-robot merged 1 commit intomilvus-io:3.0from
shaoting-huang:cp/48963-3.0
Apr 17, 2026
Merged

fix: [3.0] preserve wildcard privilege in RBAC backup/restore#49012
sre-ci-robot merged 1 commit intomilvus-io:3.0from
shaoting-huang:cp/48963-3.0

Conversation

@shaoting-huang
Copy link
Copy Markdown
Contributor

  • Catalog.RestoreRBAC routed IsAnyWord through the IsPrivilegeNameDefined /else branches and ended up calling PrivilegeGroupNameForMetastore(""), writing 'grantee-id//PrivilegeGroup'.
  • MetaTable.CheckIfRBACRestorable rejected wildcard grants with 'privilege [*] does not exist' before broadcastRestoreRBACV2 ever reached the catalog, so the catalog fix alone was unreachable on the in-process restore path.

issue: #48963
pr: #48978

@sre-ci-robot sre-ci-robot requested review from cydrain and czs007 April 14, 2026 06:52
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 14, 2026
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 14, 2026
@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Apr 14, 2026
@sre-ci-robot
Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #48978 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: ci-v2 system is enabled for this PR (3.0 branch).

To rerun ci-v2 checks, comment with:

  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests)
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e tests)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot
Copy link
Copy Markdown
Contributor

❌ CI Loop Results 5c2170d

Stage Result Duration Tests
✅ Build SUCCESS 12.4min -
❌ Code-Check FAILURE 7.6min -
❌ UT-CPP-Cov FAILURE 44.3min 7070 run, 1 failed

Total: 59min | Pipeline | Artifacts

Failed Test Logs:

@shaoting-huang shaoting-huang removed the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Apr 14, 2026
@liliu-z
Copy link
Copy Markdown
Member

liliu-z commented Apr 14, 2026

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #48978 merged to master

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

Copy link
Copy Markdown
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@shaoting-huang shaoting-huang added this to the 3.0 milestone Apr 15, 2026
@shaoting-huang shaoting-huang removed the do-not-merge/need-milestone generate by v2-label-manager label Apr 15, 2026
@shaoting-huang
Copy link
Copy Markdown
Contributor Author

ci-rerun-build-ut-cov

@sre-ci-robot
Copy link
Copy Markdown
Contributor

❌ CI Loop Results 5c2170d

Stage Result Duration Tests
✅ Build SUCCESS 8.1min -
❌ Code-Check FAILURE 2.9min -
✅ UT-CPP-Cov SUCCESS 29.2min 7070 passed

Total: 39min | Pipeline | Artifacts

- Catalog.RestoreRBAC routed IsAnyWord through the IsPrivilegeNameDefined
  /else branches and ended up calling PrivilegeGroupNameForMetastore("*"),
  writing 'grantee-id/<id>/PrivilegeGroup*'.
- MetaTable.CheckIfRBACRestorable rejected wildcard grants with
  'privilege [*] does not exist' before broadcastRestoreRBACV2 ever
  reached the catalog, so the catalog fix alone was unreachable on the
  in-process restore path.

issue: milvus-io#48963

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
(cherry picked from commit b3211b1)
@sre-ci-robot
Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #48978 merged to master

Use /refresh-label to update related check and label manually

@sre-ci-robot
Copy link
Copy Markdown
Contributor

✅ CI Loop Results 111b4cd

Stage Result Duration Tests
✅ Build SUCCESS 8.0min -
✅ Code-Check SUCCESS 4.6min -
✅ UT-GO SUCCESS 15.5min 926 passed
✅ UT-Integration SUCCESS 23.3min 46 passed
✅ UT-CPP-Cov SUCCESS 30.8min 7070 passed

Total: 55min | Pipeline | Artifacts

@mergify mergify bot added the ci-passed label Apr 16, 2026
@liliu-z
Copy link
Copy Markdown
Member

liliu-z commented Apr 17, 2026

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #48978 merged to master

Use /refresh-label to update related check and label manually

@sre-ci-robot sre-ci-robot merged commit b621ab9 into milvus-io:3.0 Apr 17, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants