enhance: decouple parquet metadata loading from GroupChunkTranslator#49026
Merged
sre-ci-robot merged 2 commits intomilvus-io:masterfrom Apr 17, 2026
Merged
enhance: decouple parquet metadata loading from GroupChunkTranslator#49026sre-ci-robot merged 2 commits intomilvus-io:masterfrom
sre-ci-robot merged 2 commits intomilvus-io:masterfrom
Conversation
Previously GroupChunkTranslator loaded and retained full parquet::FileMetaData in its constructor even when the parquet stats skip index was disabled (the default). This wasted memory across long-lived translators and coupled the translator to parquet-level types. Extract metadata loading into a free LoadGroupChunkMetadata declared in ChunkedSegmentSealedImpl.h: callers pass field_ids_for_stats only when ENABLE_PARQUET_STATS_SKIP_INDEX is on, otherwise the loader skips GetParquetMetadata() entirely and returns only the lightweight RowGroupMetadataVector. The translator now takes row_group_meta_list directly and no longer holds parquet FileMetaData. Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
mergify
bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #49026 +/- ##
==========================================
- Coverage 77.97% 77.95% -0.03%
==========================================
Files 2167 2167
Lines 356240 356274 +34
==========================================
- Hits 277783 277734 -49
- Misses 69915 69984 +69
- Partials 8542 8556 +14
🚀 New features to boost your workflow:
|
sre-ci-robot
added
the
low-code-coverage
Contributor
Author
|
/ci-rerun-e2e-default |
zhengbuqian
approved these changes
Apr 16, 2026
zhengbuqian
approved these changes
Apr 16, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sparknack, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/ci-rerun-ut-go |
Contributor
Author
|
/ci-rerun-e2e-default |
1 similar comment
Contributor
Author
|
/ci-rerun-e2e-default |
Contributor
|
/lgtm |
sre-ci-robot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…lator (#49027) issue: #49025 pr: #49026 ## Summary Cherry-pick of #49026 to the 3.0 branch. - Extract parquet metadata loading out of `GroupChunkTranslator`'s constructor into a free `LoadGroupChunkMetadata` function declared in `segcore/ChunkedSegmentSealedImpl.h`. Returns `{ row_group_meta_list, parquet_stats_by_field }`. - When `ENABLE_PARQUET_STATS_SKIP_INDEX` is off (default), the loader only reads the lightweight `RowGroupMetadataVector` (24 B per row group) and skips `GetParquetMetadata()` entirely — no `parquet::FileMetaData` is loaded or retained. - When on, stats are extracted during the same parallel file pass and the `FileMetaData` is released before the translator is constructed. - `GroupChunkTranslator` now accepts `std::vector<milvus_storage::RowGroupMetadataVector>&&` directly; the `parquet_file_metas()` / `field_id_mapping()` getters are removed. - Updated both call sites (`ChunkedSegmentSealedImpl::load_column_group_data_internal`, `JsonKeyStats`) and the translator unit test. ## Test plan - [x] Local build passes (`milvus_segcore`, `milvus_index`) on 3.0 - [x] Cherry-pick applied with auto-merge, no manual conflict resolution needed - [ ] Full CI — C++ unit tests + integration tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #49025
Summary
GroupChunkTranslator's constructor into a freeLoadGroupChunkMetadatafunction declared insegcore/ChunkedSegmentSealedImpl.h. Returns{ row_group_meta_list, parquet_stats_by_field }.ENABLE_PARQUET_STATS_SKIP_INDEXis off (default), the loader only reads the lightweightRowGroupMetadataVector(24 B per row group) and skipsGetParquetMetadata()entirely — noparquet::FileMetaDatais loaded or retained.FileMetaDatais released before the translator is constructed.GroupChunkTranslatornow acceptsstd::vector<milvus_storage::RowGroupMetadataVector>&&directly; theparquet_file_metas()/field_id_mapping()getters are removed.ChunkedSegmentSealedImpl::load_column_group_data_internal,JsonKeyStats) and the translator unit test.Test plan
milvus_segcore,milvus_index)GroupChunkTranslatorTestupdated and compiles🤖 Generated with Claude Code