test: add positive case for decay reranker on add_collection_field nullable input#49055
Open
NicoYuan1986 wants to merge 1 commit intomilvus-io:masterfrom
Open
test: add positive case for decay reranker on add_collection_field nullable input#49055NicoYuan1986 wants to merge 1 commit intomilvus-io:masterfrom
NicoYuan1986 wants to merge 1 commit intomilvus-io:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NicoYuan1986 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
sre-ci-robot
added
area/test
size/M
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
PR milvus-io#47919 (Arrow-based function chain pipeline) removed the Go-side "Function input field cannot be nullable" validation, so the previous negative case test_milvus_client_add_field_with_reranker_unsupported is no longer valid: a nullable field added via add_collection_field is now an accepted decay reranker input. Replace it with a positive case that performs search with a decay reranker referencing the newly added nullable field and asserts the search succeeds. Signed-off-by: nico <cheng.yuan@zilliz.com>
NicoYuan1986
force-pushed
the
test/add-field-decay-reranker-positive
branch
from
370ad21 to
ea1fbbb
Compare
sre-ci-robot
added
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #47919 (Arrow-based function chain pipeline) removed the Go-side
Function input field cannot be nullablevalidation ininternal/util/function/rerank/rerank_base.go. As a result, a nullable field added viaadd_collection_fieldis now an accepted input for a decay reranker.This PR replaces the previous negative case
test_milvus_client_add_field_with_reranker_unsupported(which expected the now-removed validation error) with a positive casetest_milvus_client_add_field_used_as_decay_reranker_input, covering the combinationadd_collection_field(nullable=True) + decay reranker on the new fieldand asserting that search succeeds.