feat: support numeric image IDs for Hetzner snapshots#52
Open
aaronshaf wants to merge 1 commit intomrsimonemms:mainfrom
Open
feat: support numeric image IDs for Hetzner snapshots#52aaronshaf wants to merge 1 commit intomrsimonemms:mainfrom
aaronshaf wants to merge 1 commit intomrsimonemms:mainfrom
Conversation
aaronshaf
force-pushed
the
feat/snapshot-id-support
branch
from
ebbbda9 to
de0d732
Compare
GetByNameAndArchitecture only works for named images. Hetzner snapshots have no name — only a numeric ID. If DISK_IMAGE is a numeric string, look up by ID directly using Image.GetByID. Otherwise fall back to the existing name+architecture lookup. This allows users to boot DevPod workspaces from a pre-baked Hetzner snapshot, skipping slow provisioning steps. Signed-off-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
aaronshaf
force-pushed
the
feat/snapshot-id-support
branch
from
f81ac11 to
808d7d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DISK_IMAGEcurrently only supports named images viaGetByNameAndArchitecture. Hetzner snapshots have nonamefield — only a numeric ID and a description. This makes it impossible to boot a DevPod workspace from a snapshot, even though snapshots are useful for pre-baking Docker images and other setup to speed up workspace creation.Solution
If
DISK_IMAGEis a numeric string, look up the image by ID usingImage.GetByID. Otherwise fall back to the existing name+architecture lookup. This is fully backwards-compatible — existing string-basedDISK_IMAGEvalues continue to work unchanged.Usage
Changes
pkg/hetzner/hetzner.go: detect numericDISK_IMAGEand useGetByIDinstead ofGetByNameAndArchitecturestrconvwas already imported so no new dependencies are needed.