Skip to content

chore(docs): add Claude config and update README architecture diagram#400

Merged
nanotaboada merged 3 commits intomasterfrom
docs/refresh-readme-and-custom-instructions
Mar 9, 2026
Merged

chore(docs): add Claude config and update README architecture diagram#400
nanotaboada merged 3 commits intomasterfrom
docs/refresh-readme-and-custom-instructions

Conversation

@nanotaboada
Copy link
Copy Markdown
Owner

@nanotaboada nanotaboada commented Mar 9, 2026

Summary by CodeRabbit

  • Documentation

    • Updated badges and styling for visibility
    • Reorganized architecture diagram and navigation headings
    • Updated API endpoint references
    • Renamed deployment section from Docker to Containers
    • Relabeled guidance document header to "Custom Instructions"
  • Chores

    • Added static configuration for model selection
    • Removed token-counting utility script

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 9, 2026

Warning

Rate limit exceeded

@nanotaboada has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 21 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1d3b5a7d-ed1f-4a35-ab77-e3b476eab2f5

📥 Commits

Reviewing files that changed from the base of the PR and between 5312ded and cbc0f0b.

📒 Files selected for processing (2)
  • CLAUDE.md
  • README.md

Walkthrough

The PR adds Claude integration configuration, renames AI instruction documentation to "Custom Instructions", removes token-counting tooling, and updates README with new badges, restructured architecture diagram, revised section names, and API endpoint changes.

Changes

Cohort / File(s) Summary
Claude Integration
.claude/settings.json
Adds new configuration file specifying the Claude model selection ("claude-sonnet-4-6") for Claude integration.
AI Instructions Documentation
.github/copilot-instructions.md
Changes the document header from "GitHub Copilot Instructions" to "Custom Instructions" (documentation/labeling change).
README Updates
README.md
Updates badges (adds GitHub Copilot, Claude, CodeRabbit PRs), renames "Docker" → "Containers", restructures the Mermaid architecture diagram (orientation and subgraphs), adjusts wording across docs, and changes API reference GET /players/squad/{squadNumber} → GET /players/{squadNumber}.
Script Removal
scripts/count-tokens.sh
Removes token-counting script that used Python/tiktoken for token analysis with fallback approximations and optional auto-install behavior.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits format (chore:) and is under 80 characters (69). It accurately describes the main changes: Claude configuration addition and README architecture diagram updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/refresh-readme-and-custom-instructions
  • 🛠️ sync documentation: Commit on current branch
  • 🛠️ sync documentation: Create PR
  • 🛠️ enforce http error handling: Commit on current branch
  • 🛠️ enforce http error handling: Create PR
  • 🛠️ idiomatic review: Commit on current branch
  • 🛠️ idiomatic review: Create PR
  • 🛠️ verify api contract: Commit on current branch
  • 🛠️ verify api contract: Create PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/copilot-instructions.md (1)

29-30: ⚠️ Potential issue | 🟡 Minor

Use one AutoMapper directory name throughout.

The structure block says AutoMapper lives under Profiles/, but the endpoint workflow on Line 111 sends contributors to Mappings/PlayerMappingProfile. That contradiction makes the edit path unclear; align both sections to the actual repo layout.

Also applies to: 111-111

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/copilot-instructions.md around lines 29 - 30, The docs reference
AutoMapper as "Profiles/" but elsewhere (e.g., the endpoint workflow referencing
Mappings/PlayerMappingProfile) uses "Mappings/"; pick one consistent directory
name and update both locations to match the actual repo layout — for example,
rename either all "Profiles/" occurrences to "Mappings/" (including the endpoint
workflow reference to PlayerMappingProfile) or vice versa so that references
like Profiles/ and Mappings/PlayerMappingProfile are consistent across the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CLAUDE.md`:
- Line 1: The import path in CLAUDE.md is missing the required '@' prefix so
Claude Code won't load the instructions file; update the reference to use the
'@' prefix (i.e., change ".github/copilot-instructions.md" to
"@.github/copilot-instructions.md" or the correct "@path/to/file" form) so the
additional instruction file is actually imported by Claude Code.

In `@README.md`:
- Around line 192-195: The two documented routes `GET /players/{id}` and `GET
/players/{squadNumber}` are ambiguous because they share the same URI pattern;
update the README to disambiguate by either collapsing them into a single
supported lookup route (pick one of `GET /players/{id}` and remove the other) or
by documenting distinct templates such as `GET /players/id/{id}` for lookup by
database id and `GET /players/squad/{squadNumber}` for lookup by squad number;
ensure you update the quick reference lines to use the exact route templates
(`GET /players/id/{id}` and/or `GET /players/squad/{squadNumber}`) and mention
any authentication requirement for the id-based route (`GET /players/id/{id}`)
if applicable.

---

Outside diff comments:
In @.github/copilot-instructions.md:
- Around line 29-30: The docs reference AutoMapper as "Profiles/" but elsewhere
(e.g., the endpoint workflow referencing Mappings/PlayerMappingProfile) uses
"Mappings/"; pick one consistent directory name and update both locations to
match the actual repo layout — for example, rename either all "Profiles/"
occurrences to "Mappings/" (including the endpoint workflow reference to
PlayerMappingProfile) or vice versa so that references like Profiles/ and
Mappings/PlayerMappingProfile are consistent across the file.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5edd3498-91a1-4b01-be28-76eecaf1f58c

📥 Commits

Reviewing files that changed from the base of the PR and between 7a29f0b and 673c7a6.

📒 Files selected for processing (5)
  • .claude/settings.json
  • .github/copilot-instructions.md
  • CLAUDE.md
  • README.md
  • scripts/count-tokens.sh
💤 Files with no reviewable changes (1)
  • scripts/count-tokens.sh

Comment thread CLAUDE.md Outdated
Comment thread README.md
nanotaboada and others added 2 commits March 9, 2026 09:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: coderabbitai[bot]
<136622811+coderabbitai[bot]@users.noreply.github.com>
@nanotaboada nanotaboada force-pushed the docs/refresh-readme-and-custom-instructions branch from 5312ded to cbc0f0b Compare March 9, 2026 12:40
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 9, 2026

@nanotaboada nanotaboada merged commit 5cfbf85 into master Mar 9, 2026
10 checks passed
@nanotaboada nanotaboada deleted the docs/refresh-readme-and-custom-instructions branch March 9, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant