-
Notifications
You must be signed in to change notification settings - Fork 18
feat(data): normalize player dataset to 2022 FIFA World Cup Argentina squad (#435) #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
14efe16
feat(data): normalize 2022 World Cup Argentina squad dataset (#435)
nanotaboada 690e8f6
chore(ci): harden SonarCloud exclusions and CodeRabbit paths (#435)
nanotaboada 9586e35
fix(data): sync JSON literal and derive Delete test squadNumber (#435)
nanotaboada f260b06
chore(ci): add .sonarcloud.properties for automatic analysis (#435)
nanotaboada 9a04c82
chore(ci): drop sonar-project.properties for .sonarcloud.properties (…
nanotaboada be21405
fix(data): exclude Lo Celso from seed data, keep as Create/Delete fix…
nanotaboada 075c766
chore(ci): remove stale sonar-project.properties reference in comment…
nanotaboada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| # ============================================================================= | ||
| # SonarCloud Automatic Analysis configuration | ||
| # https://docs.sonarsource.com/sonarqube-cloud/advanced-setup/automatic-analysis/ | ||
| # | ||
| # SonarCloud's automatic analysis (GitHub App, no CI workflow) reads THIS file, | ||
| # not sonar-project.properties. Wildcard patterns are NOT supported here, so | ||
| # all exclusion paths must be listed explicitly. | ||
| # | ||
| # sonar-project.properties is kept for documentation and as a fallback if | ||
| # CI-based analysis is ever introduced. | ||
| # ============================================================================= | ||
|
|
||
| sonar.sources=src/ | ||
| sonar.tests=test/ | ||
| sonar.sourceEncoding=UTF-8 | ||
|
|
||
| # ============================================================================= | ||
| # Global exclusions | ||
| # ============================================================================= | ||
|
|
||
| sonar.exclusions=\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414191223_InitialCreate.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414191223_InitialCreate.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414195445_SeedStarting11.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414195445_SeedStarting11.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20251221220614_SeedSubstitutes.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20251221220614_SeedSubstitutes.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20260329000000_NormalizePlayerDataset.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20260329000000_NormalizePlayerDataset.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/PlayerDbContextModelSnapshot.cs | ||
|
|
||
| # ============================================================================= | ||
| # Coverage exclusions | ||
| # Test files and generated/infrastructure code should not count against | ||
| # production code coverage metrics. | ||
| # ============================================================================= | ||
|
|
||
| sonar.coverage.exclusions=\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Unit/PlayerControllerTests.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Unit/PlayerServiceTests.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Unit/PlayerValidatorTests.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Utilities/DatabaseFakes.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Utilities/PlayerFakes.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Utilities/PlayerMocks.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Utilities/PlayerStubs.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Usings.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414191223_InitialCreate.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414191223_InitialCreate.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414195445_SeedStarting11.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414195445_SeedStarting11.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20251221220614_SeedSubstitutes.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20251221220614_SeedSubstitutes.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20260329000000_NormalizePlayerDataset.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20260329000000_NormalizePlayerDataset.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/PlayerDbContextModelSnapshot.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Data/PlayerDbContext.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Program.cs | ||
|
|
||
| # ============================================================================= | ||
| # Duplicate code (CPD) exclusions | ||
| # Automatic analysis does not support wildcard patterns, so each file is | ||
| # listed explicitly. | ||
| # | ||
| # Migrations — EF Core migration files are intentionally repetitive | ||
| # (sequential InsertData/UpdateData/Sql calls). | ||
| # | ||
| # PlayerDbContext.cs — scaffolded EF Core infrastructure. | ||
| # | ||
| # PlayerData.cs — parallel WithId/without-Id method pairs mirror each other | ||
| # by design; duplication is structural, not accidental. | ||
| # | ||
| # PlayerRequestModelValidator.cs — the "Create" and "Update" rule sets share | ||
| # common rules by design; duplication is intentional. | ||
| # | ||
| # Test files — Fakes, Mocks, and Stubs are intentionally repetitive by design. | ||
| # ============================================================================= | ||
|
|
||
| sonar.cpd.exclusions=\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414191223_InitialCreate.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414191223_InitialCreate.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414195445_SeedStarting11.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20250414195445_SeedStarting11.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20251221220614_SeedSubstitutes.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20251221220614_SeedSubstitutes.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20260329000000_NormalizePlayerDataset.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/20260329000000_NormalizePlayerDataset.Designer.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Migrations/PlayerDbContextModelSnapshot.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Data/PlayerDbContext.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Utilities/PlayerData.cs,\ | ||
| src/Dotnet.Samples.AspNetCore.WebApi/Validators/PlayerRequestModelValidator.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Unit/PlayerControllerTests.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Unit/PlayerServiceTests.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Unit/PlayerValidatorTests.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Utilities/DatabaseFakes.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Utilities/PlayerFakes.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Utilities/PlayerMocks.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Utilities/PlayerStubs.cs,\ | ||
| test/Dotnet.Samples.AspNetCore.WebApi.Tests/Usings.cs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
69 changes: 69 additions & 0 deletions
69
...et.Samples.AspNetCore.WebApi/Migrations/20260329000000_NormalizePlayerDataset.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.