[wip] Add windows nightlies#1414
Draft
douglascamata wants to merge 2 commits intoopen-telemetry:mainfrom
Draft
Conversation
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
mowies
reviewed
Mar 16, 2026
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Member
|
@douglascamata is this relevant? was it done already? |
Member
Author
|
Oh wow, I didn't notice this was about to get auto closed, thanks for the ping @mowies. I think it's still relevant to help show that Windows is strongly supported as tier 2 platform. I'm a bit short on time to test the nightlies for now, but I will try to get back to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to add Windows nightlies.
It was previously attempted but there were some failures because of strict versioning requirements on the
wxsfiles.Here we try to set the nightly version to:
{{ .RawVersion }}.{{ .Now.Format "00215" }}.According to https://pkg.go.dev/time, the time format
00215will give us: zero-padded day of the year and hour in 24-hour format. This should be enough for the nightlies, as they run only once per day.This should close #1091.