[chore] Add validation to push-tags Makefile target#1461
Open
crobert-1 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[chore] Add validation to push-tags Makefile target#1461crobert-1 wants to merge 2 commits intoopen-telemetry:mainfrom
crobert-1 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
crobert-1
commented
Apr 14, 2026
| fi | ||
|
|
||
| REMOTE="${REMOTE:-git@github.com:open-telemetry/opentelemetry-collector-releases.git}" | ||
| VALIDATE="${VALIDATE:-true}" |
Member
Author
There was a problem hiding this comment.
If it's preferred, we could rename VALIDATE to be more specific to its current purpose, something like VALIDATE_TAG_VERSION.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When releasing
v0.150.0, I misread directions and didn't understand steps 1 and 2 were two different PRs. This resulted in needing to create a patch releasev0.150.1to address the incorrect contents of thev0.150.0tag.This PR moves the functionality of creating and pushing a tag to a standalone script and validates that the manifests have been properly updated by the
[chore] Prepare releasePR.Testing:
Disclosure: I used Codex and Claude to generate most of this script.