docs: fix wording in Sorbet example comment#265
Open
Rohan5commit wants to merge 1 commit intoopenai:mainfrom
Open
docs: fix wording in Sorbet example comment#265Rohan5commit wants to merge 1 commit intoopenai:mainfrom
Rohan5commit wants to merge 1 commit intoopenai:mainfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # you will see a red squiggly line on `params` due to a quirk of the sorbet type system. | ||
| # | ||
| # this file will still infact, run correctly as uncommented. | ||
| # this file will still in fact, run correctly as uncommented. |
There was a problem hiding this comment.
The punctuation here reads awkwardly/incorrectly: "still in fact, run". Consider either removing the comma ("still in fact run") or moving it to the standard parenthetical form ("still, in fact, run"), and "when uncommented" reads clearer than "as uncommented".
Suggested change
| # this file will still in fact, run correctly as uncommented. | |
| # this file will still, in fact, run correctly when uncommented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infactin the Sorbet example commentRelated issue
Guideline alignment
examples/, which the guide says is not generator-managed.Validation
git diff --check