Open
Conversation
added 17 commits
March 28, 2024 03:10
asmorkalov
reviewed
Apr 16, 2024
Comment on lines
+21
to
+22
| if sys.version_info[0] < 3 or sys.version_info[1] < 5: | ||
| raise Exception("Python 3.5 or greater is required. Try running `python3 download_collection.py`") |
Contributor
There was a problem hiding this comment.
Please use Version for it: https://stackoverflow.com/questions/11887762/how-do-i-compare-version-numbers-in-python
| normL2Rgb = np.linalg.norm(colorDiff, ord=2) / (width * height) | ||
| print("rgb L2: %f Inf: %f" % (normL2Rgb, normInfRgb)) | ||
|
|
||
| cv.imwrite(color_diff_path, (colorDiff.reshape((height, width, 3)) + 1) * 0.5 * 255.0) |
Author
There was a problem hiding this comment.
because difference range is 2x bigger than value range
| colorGl = colorGl.astype(np.float32) * (1.0/255.0) | ||
| colorDiff = np.ravel(colorGl - colorRasterize) | ||
| normInfRgb = np.linalg.norm(colorDiff, ord=np.inf) | ||
| normL2Rgb = np.linalg.norm(colorDiff, ord=2) / (width * height) |
Contributor
There was a problem hiding this comment.
I propose to report min/max/average, but not only value normalized on pixel count. In case if the scene is sparse and most of pixels are background the current value is not informative.
| position = np.array([0.0, 0.0, zat], dtype=np.float32) | ||
| lookat = np.array([0.0, 0.0, 0.0], dtype=np.float32) | ||
| upVector = np.array([0.0, 1.0, 0.0], dtype=np.float32) | ||
| cameraPose = lookAtMatrixCal(position, lookat, upVector) |
Contributor
There was a problem hiding this comment.
Looks like we need to add it to OpenCV as API.
asmorkalov
reviewed
Apr 16, 2024
Comment on lines
+1
to
+2
| # Script to download Scanned Objects by Google Research dataset and Stanford models | ||
| # Distributed by CC-BY 4.0 License |
Contributor
There was a problem hiding this comment.
Please extract Google owned code as dedicated file with own license header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
Adding a script that downloads models from a specific dataset, runs several 3D algorithms on it and calculates accuracy.
TODO:
triangleRasterize(): assign vertex color based on a color from a texture