Skip to content

refactor: rework how nock is setup and used to harden tests#395

Open
kamilogorek wants to merge 1 commit intoopenfga:mainfrom
kamilogorek:cleanup-tests
Open

refactor: rework how nock is setup and used to harden tests#395
kamilogorek wants to merge 1 commit intoopenfga:mainfrom
kamilogorek:cleanup-tests

Conversation

@kamilogorek
Copy link
Copy Markdown
Contributor

@kamilogorek kamilogorek commented May 3, 2026

This PR hardens everything around nock usage for network-based tests.

  • setup global assertions for pending nock requests
  • stop using manual scope assertions
  • cleanup network setup
  • remove duplicated mocks setup/cleanup

NOTE: will rebase once #394 is merged

@kamilogorek kamilogorek requested a review from a team as a code owner May 3, 2026 09:06
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 581e9942-b759-4563-a9a7-0b065a834ff9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kamilogorek kamilogorek changed the base branch from fix/default-retry-params to main May 4, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant