Skip to content

ACM-33186: Revert Renovate configuration for Hive updates#812

Open
shay23bra wants to merge 1 commit intoopenshift:mainfrom
shay23bra:ACM-33186-Revert-Renovate-configuration-for-Hive-updates-main
Open

ACM-33186: Revert Renovate configuration for Hive updates#812
shay23bra wants to merge 1 commit intoopenshift:mainfrom
shay23bra:ACM-33186-Revert-Renovate-configuration-for-Hive-updates-main

Conversation

@shay23bra
Copy link
Copy Markdown
Contributor

@shay23bra shay23bra commented Apr 23, 2026

Revert the Renovate/MintMaker configuration that enables hive/apis digest tracking.
MintMaker generates bare commit hashes instead of proper Go pseudo-versions,
which breaks go.mod.

Reverts changes from ACM-29247 / ACM-29261 / ACM-29244.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 23, 2026

@shay23bra: This pull request references ACM-33186 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Revert the Renovate/MintMaker configuration that enables hive/apis digest tracking.
MintMaker generates bare commit hashes instead of proper Go pseudo-versions,
which breaks go.mod.

Reverts changes from ACM-29247 / ACM-29261 / ACM-29244.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Walkthrough

The Renovate configuration is updated to disable Go module dependency management by removing gomod from the enabled managers list and deleting all associated gomod configuration blocks and rules, resulting in a net reduction of 38 lines.

Changes

Cohort / File(s) Summary
Renovate Configuration
renovate.json
Removed "gomod" from enabledManagers array, deleted the gomod manager configuration block with post-update options and nested package rules, and removed two packageRules entries that matched the gomod manager (including a rule targeting github.com/openshift/hive/apis).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5-10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title 'ACM-33186: Revert Renovate configuration for Hive updates' directly describes the main change: removing gomod manager configuration from Renovate that was previously added for Hive/apis tracking.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This custom check is not applicable to the provided pull request. The PR exclusively modifies renovate.json, a Renovate configuration file, and does not alter any test files.
Test Structure And Quality ✅ Passed The PR modifies only renovate.json, a configuration file for dependency management, and contains no changes to test code, Ginkgo test suites, or test-related code.
Microshift Test Compatibility ✅ Passed PR only modifies renovate.json configuration file and adds no new Ginkgo e2e tests, making this check inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only renovate.json and does not add any Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only renovate.json, removing Go module dependency tracking. No deployment manifests, operator code, or Kubernetes resources with scheduling constraints present.
Ote Binary Stdout Contract ✅ Passed This PR only modifies renovate.json, a configuration file not executable code subject to OTE Binary Stdout Contract constraints.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies renovate.json configuration file with no new Ginkgo e2e tests added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from imiller0 and romfreiman April 23, 2026 12:57
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shay23bra
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shay23bra
Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

@shay23bra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibio-reinstall-v6v4 2dbc2f7 link false /test ibio-reinstall-v6v4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants