Skip to content

MULTIARCH-6034: Increase memory limits for integration tests#187

Open
AnnaZivkovic wants to merge 1 commit intoopenshift:v1.xfrom
AnnaZivkovic:v1.x-fix-konflux-intagration
Open

MULTIARCH-6034: Increase memory limits for integration tests#187
AnnaZivkovic wants to merge 1 commit intoopenshift:v1.xfrom
AnnaZivkovic:v1.x-fix-konflux-intagration

Conversation

@AnnaZivkovic
Copy link
Copy Markdown

@AnnaZivkovic AnnaZivkovic commented Apr 16, 2026

The integration test pipeline was failing in two ways:

  1. Out of Memory (OOM): Tests running with the race detector were being killed mid-execution when the memory limit (4Gi) was exceeded. This issue appeared after recent dependency updates (particularly cilium/ebpf and Go
    module updates between commits 6c31432 and fc4c55f).

  2. Group Test Incompatibility: The pipeline used fieldRef to access PAC annotations (pac.test.appstudio.openshift.io/source-repo-url and pac.test.appstudio.openshift.io/sha), which works for component tests but not
    for group tests. Group tests don't populate these annotations, causing the pipeline to fail with "URL and REVISION must be set".

Changes

1. Increased Memory Limits

  • Memory limit: 4Gi → 8Gi
  • Memory requests: 1Gi → 2Gi

The race detector increases memory usage by 5-10x, and the updated dependencies require more memory during test execution.

2. Updated to Use SNAPSHOT Parameter (New Konflux Standard)

Converted from PAC annotation-based approach to the Konflux-standard SNAPSHOT parameter:

  • Primary: Extracts git URL and revision from the SNAPSHOT parameter using Python JSON parsing
  • Fallback: For group tests where git info isn't in the SNAPSHOT parameter, fetches the Snapshot Kubernetes resource and extracts component information
  • No external dependencies: Uses Python (built into golang-builder image) instead of jq

3. Support for Both Test Types

  • Component tests: Works with SNAPSHOT parameter containing git source info
  • Group tests: Falls back to fetching Snapshot resource when needed
  • Automatically installs oc client if needed to query Snapshot resources

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f317536-ac41-4d33-9642-81cee630af99

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aleskandro for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AnnaZivkovic AnnaZivkovic force-pushed the v1.x-fix-konflux-intagration branch from c9cb346 to 1b90624 Compare April 16, 2026 22:57
@AnnaZivkovic
Copy link
Copy Markdown
Author

/retest

@AnnaZivkovic AnnaZivkovic force-pushed the v1.x-fix-konflux-intagration branch from 1b90624 to 3e8db39 Compare April 17, 2026 01:15
@AnnaZivkovic AnnaZivkovic changed the title Increase memory limits for integration tests MULTIARCH-6034: Increase memory limits for integration tests Apr 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 17, 2026

@AnnaZivkovic: This pull request references MULTIARCH-6034 which is a valid jira issue.

Details

In response to this:

Tests were being OOMed with 4Gi limit when running with race detector after recent dependency updates. Doubling to 8Gi to accommodate increased memory usage from cilium/ebpf and other vendor updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2026
@AnnaZivkovic
Copy link
Copy Markdown
Author

/retest

@AnnaZivkovic AnnaZivkovic force-pushed the v1.x-fix-konflux-intagration branch 2 times, most recently from cc851e1 to d1ae641 Compare April 17, 2026 16:38
@AnnaZivkovic
Copy link
Copy Markdown
Author

/retest

Tests were being OOMed with 4Gi limit when running with race
detector after recent dependency updates. Increased to 8Gi to
accommodate increased memory usage from cilium/ebpf and other
vendor updates.

Also updated to support both component and group test types by
parsing the SNAPSHOT parameter using Python, with fallback to
fetching Snapshot resources when git info is not in the parameter.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@AnnaZivkovic AnnaZivkovic force-pushed the v1.x-fix-konflux-intagration branch from d1ae641 to 6534d5c Compare April 21, 2026 21:58
@AnnaZivkovic
Copy link
Copy Markdown
Author

Pipeline passes: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/multiarch-tuning-ope-tenant/applications/multiarch-tuning-operator-v1-x/pipelineruns/multiarch-tuning-operator-v1-x-integration-tests-mdgm6

Unfortunately, there is no built-in way to make the IntegrationTestScenario dynamically fetch the pipeline definition from a Pull Request branch without modifying the resource. So the integration test will fail until merged.

@AnnaZivkovic
Copy link
Copy Markdown
Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 22, 2026

@AnnaZivkovic: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants