MULTIARCH-6034: Increase memory limits for integration tests#187
MULTIARCH-6034: Increase memory limits for integration tests#187AnnaZivkovic wants to merge 1 commit intoopenshift:v1.xfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
c9cb346 to
1b90624
Compare
|
/retest |
1b90624 to
3e8db39
Compare
|
@AnnaZivkovic: This pull request references MULTIARCH-6034 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
cc851e1 to
d1ae641
Compare
|
/retest |
Tests were being OOMed with 4Gi limit when running with race detector after recent dependency updates. Increased to 8Gi to accommodate increased memory usage from cilium/ebpf and other vendor updates. Also updated to support both component and group test types by parsing the SNAPSHOT parameter using Python, with fallback to fetching Snapshot resources when git info is not in the parameter. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
d1ae641 to
6534d5c
Compare
|
Unfortunately, there is no built-in way to make the IntegrationTestScenario dynamically fetch the pipeline definition from a Pull Request branch without modifying the resource. So the integration test will fail until merged. |
|
/retest |
|
@AnnaZivkovic: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The integration test pipeline was failing in two ways:
Out of Memory (OOM): Tests running with the race detector were being killed mid-execution when the memory limit (4Gi) was exceeded. This issue appeared after recent dependency updates (particularly cilium/ebpf and Go
module updates between commits 6c31432 and fc4c55f).
Group Test Incompatibility: The pipeline used
fieldRefto access PAC annotations (pac.test.appstudio.openshift.io/source-repo-urlandpac.test.appstudio.openshift.io/sha), which works for component tests but notfor group tests. Group tests don't populate these annotations, causing the pipeline to fail with "URL and REVISION must be set".
Changes
1. Increased Memory Limits
The race detector increases memory usage by 5-10x, and the updated dependencies require more memory during test execution.
2. Updated to Use SNAPSHOT Parameter (New Konflux Standard)
Converted from PAC annotation-based approach to the Konflux-standard SNAPSHOT parameter:
SNAPSHOTparameter using Python JSON parsing3. Support for Both Test Types
occlient if needed to query Snapshot resources