fix: reclassify MetaRegistryFailure as unexpected error#141
Merged
EnderOfWorlds007 merged 1 commit intomainfrom May 7, 2026
Merged
fix: reclassify MetaRegistryFailure as unexpected error#141EnderOfWorlds007 merged 1 commit intomainfrom
EnderOfWorlds007 merged 1 commit intomainfrom
Conversation
Renames the error thrown when the CDM meta-registry fails to return a live contract address from BadRegistryLookup to MetaRegistryFailure. This removes it from the isExpectedCliError allowlist so it registers as cli.expected=false in Sentry — it is an infra failure, not a user mistake.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getRegistryContractwhen the CDM meta-registry fails to return a live contract address fromBadRegistryLookup→MetaRegistryFailureisExpectedCliErrorallowlist so it registers ascli.expected=falsein Sentry — this is an infra failure, not a user mistakeBadRegistryLookupremains in the allowlist for other registry errors that are legitimate user-facing conditionsTest plan
pnpm test— 492 tests passing