refactor(vue): use new bpmn-visualization-addons methods to simplify#624
Merged
refactor(vue): use new bpmn-visualization-addons methods to simplify#624
Conversation
tbouffard
force-pushed
the
refactor/vue_use_new_bv-addons_methods
branch
from
7424332 to
b367f8d
Compare
…tion Bump bpmn-visualization-addons from 0.8.0 to 0.9.0
tbouffard
force-pushed
the
refactor/vue_use_new_bv-addons_methods
branch
from
b367f8d to
cece3a7
Compare
|
🎊 PR Preview 842073f has been successfully built and deployed to https://process-analytics-bpmn-visualization-examples-pr_preview-pr-624.surge.sh 🕐 Build time: 0.01s
🤖 By surge-preview |
tbouffard
changed the title
There was a problem hiding this comment.
Pull Request Overview
Refactors the Vue project to use updated methods from bpmn-visualization-addons to properly filter flow nodes by excluding BPMN artifacts, which were incorrectly included by the original ShapeUtil.flowNodeKinds() method.
- Updates dependency to bpmn-visualization-addons v0.9.0 to access new filtering methods
- Replaces manual artifact filtering with ShapeUtil.isFlowNode() method for cleaner code
- Extracts repeated fit options into a reusable constant
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/typescript-vue/src/app.vue | Refactors flow node filtering logic and extracts fit options constant |
| projects/typescript-vue/package.json | Updates bpmn-visualization-addons dependency to v0.9.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
Converted to draft to integrate review feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original ShapeUtil.flowNodeKinds() method from bpmn-visualization includes BPMN artifacts.
So use a convenient method from bv-addons to workaround the problem.