Deprecate event_loop_policy fixture#1421
Merged
seifertm merged 2 commits intopytest-dev:mainfrom Apr 25, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
+ Coverage 94.53% 94.56% +0.03%
==========================================
Files 2 2
Lines 512 515 +3
Branches 61 62 +1
==========================================
+ Hits 484 487 +3
Misses 22 22
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seifertm
approved these changes
Apr 25, 2026
Contributor
seifertm
left a comment
There was a problem hiding this comment.
I like the mechanism to check whether the fixture has been overridden and adding a deprecation notice to the docs, instead of removing it from the documentation. Both are improvents on how pytest-asyncio handled theses things in previous versions.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit a deprecation warning when a user uses the
event_loop_policyfixture (determined by the hook__module__). Add deprecation notice to documentation.One documentation code snippet tests was failing due to the change. As I was about to update it, I noticed that the snippet wasn't actually used anywhere, so I deleted it.
Closes #1419