Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,34 @@ jobs:
path: coverage/coverage.*
if-no-files-found: error

test-pytest-dev:
name: ubuntu - Python 3.13 - pytest dev
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: ubuntu - Python 3.13 - pytest dev
name: ubuntu - Python ${{ env.PYTHON_LATEST }} - pytest dev

runs-on: ubuntu-latest
continue-on-error: true

steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
persist-credentials: false
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405
with:
python-version: '3.13'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just use the PYTHON_LATEST, in order to keep Python updates in the workflow simple.

Suggested change
python-version: '3.13'
python-version: ${{ env.PYTHON_LATEST }}

- name: Install dependencies
run: |
python -VV
python -m site
python -m pip install --upgrade pip
python -m pip install --upgrade coverage[toml] virtualenv tox tox-gh-actions
python -m pip install --upgrade "git+https://github.com/pytest-dev/pytest.git@main"
- name: Run tox targets for pytest development version
run: python -m tox
- name: Store coverage data
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f
with:
name: coverage-pytest-dev
path: coverage/coverage.*
if-no-files-found: error

lint-github-actions:
name: Lint GitHub Actions
permissions:
Expand All @@ -109,7 +137,7 @@ jobs:
check:
name: Check
if: always()
needs: [build, lint, test]
needs: [build, lint, test, test-pytest-dev]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to make this a mandatory CI job. It's completely fine to merge code, even though test-pytest-dev does not run successfully.

We want to have the CI job to make incompatibilities visible only, not to block on them.

Suggested change
needs: [build, lint, test, test-pytest-dev]
needs: [build, lint, test]

runs-on: ubuntu-latest
steps:
- name: Decide whether the needed jobs succeeded or failed
Expand Down
Loading