-
Notifications
You must be signed in to change notification settings - Fork 181
Add CI job for pytest development version #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -100,6 +100,34 @@ jobs: | |||||
| path: coverage/coverage.* | ||||||
| if-no-files-found: error | ||||||
|
|
||||||
| test-pytest-dev: | ||||||
| name: ubuntu - Python 3.13 - pytest dev | ||||||
| runs-on: ubuntu-latest | ||||||
| continue-on-error: true | ||||||
|
|
||||||
| steps: | ||||||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||||||
| with: | ||||||
| persist-credentials: false | ||||||
| - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 | ||||||
| with: | ||||||
| python-version: '3.13' | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's just use the PYTHON_LATEST, in order to keep Python updates in the workflow simple.
Suggested change
|
||||||
| - name: Install dependencies | ||||||
| run: | | ||||||
| python -VV | ||||||
| python -m site | ||||||
| python -m pip install --upgrade pip | ||||||
| python -m pip install --upgrade coverage[toml] virtualenv tox tox-gh-actions | ||||||
| python -m pip install --upgrade "git+https://github.com/pytest-dev/pytest.git@main" | ||||||
| - name: Run tox targets for pytest development version | ||||||
| run: python -m tox | ||||||
| - name: Store coverage data | ||||||
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f | ||||||
| with: | ||||||
| name: coverage-pytest-dev | ||||||
| path: coverage/coverage.* | ||||||
| if-no-files-found: error | ||||||
|
|
||||||
| lint-github-actions: | ||||||
| name: Lint GitHub Actions | ||||||
| permissions: | ||||||
|
|
@@ -109,7 +137,7 @@ jobs: | |||||
| check: | ||||||
| name: Check | ||||||
| if: always() | ||||||
| needs: [build, lint, test] | ||||||
| needs: [build, lint, test, test-pytest-dev] | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we want to make this a mandatory CI job. It's completely fine to merge code, even though test-pytest-dev does not run successfully. We want to have the CI job to make incompatibilities visible only, not to block on them.
Suggested change
|
||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Decide whether the needed jobs succeeded or failed | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.