Skip to content

gh-131704: add PyComplex_FromString() and PyNumber_Complex() C-API functions#132347

Closed
skirpichev wants to merge 10 commits intopython:mainfrom
skirpichev:add-missing-complexapi/131704
Closed

gh-131704: add PyComplex_FromString() and PyNumber_Complex() C-API functions#132347
skirpichev wants to merge 10 commits intopython:mainfrom
skirpichev:add-missing-complexapi/131704

Conversation

@skirpichev
Copy link
Copy Markdown
Member

@skirpichev skirpichev commented Apr 10, 2025 •
edited
Loading

📚 Documentation preview 📚: https://cpython-previews--132347.org.readthedocs.build/

For reviewers:

  • it's a feature-complete pr, ready for review (but see issue thread)
  • I can split it on separate pr, per commits
  • nb_complex slot part is optional and might be implemented differently (i.e. without reusing reserved slot)

@bedevere-app bedevere-app Bot mentioned this pull request Apr 10, 2025
Open
@skirpichev skirpichev force-pushed the add-missing-complexapi/131704 branch from 2ee9ccb to be76690 Compare April 10, 2025 08:24
@skirpichev skirpichev closed this Oct 10, 2025
@skirpichev skirpichev deleted the add-missing-complexapi/131704 branch October 10, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 will be requested when the pull request is marked ready for review kumaraditya303 is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle will be requested when the pull request is marked ready for review pganssle is a code owner

@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland will be requested when the pull request is marked ready for review StanFromIreland is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger will be requested when the pull request is marked ready for review rhettinger is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity will be requested when the pull request is marked ready for review ZeroIntensity is a code owner

@encukou encukou Awaiting requested review from encukou encukou will be requested when the pull request is marked ready for review encukou is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skirpichev