gh-136229: Remove Platform Emscripten is not supported warning#136230
gh-136229: Remove Platform Emscripten is not supported warning#136230freakboy3742 merged 2 commits intopython:mainfrom
Conversation
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Can you also update https://peps.python.org/pep-0011/#tier-3 ?
|
By the way, https://peps.python.org/pep-0776/ is still a draft. |
blockchainGuru1018
left a comment
There was a problem hiding this comment.
@hoodmane approved the pr
| [x86_64-*-freebsd*/clang], [PY_SUPPORT_TIER=3], dnl FreeBSD on AMD64 | ||
| [aarch64-apple-ios*-simulator/clang], [PY_SUPPORT_TIER=3], dnl iOS Simulator on arm64 | ||
| [aarch64-apple-ios*/clang], [PY_SUPPORT_TIER=3], dnl iOS on ARM64 | ||
| [aarch64-apple-ios*/clang], [PY_SUPPORT_TIER=3], dnl iOS on ARM64 |
There was a problem hiding this comment.
I think it would be better to indent the other entries more to line up with the line containing aarch64-apple-ios*-simulator/clang (so that all the PY_SUPPORT_TIER lines are aligned)
There was a problem hiding this comment.
Agreed. I'll push a change to that effect.
Noted; however, Emscripten is a bit of a weird case. WASI and Emscripten were both at Tier 3 for Py3.12, without a PEP existing at all; WASI is at Tier 2, and doesn't have a PEP. In addition, the Steering Council has approved restoration to Tier 3 for Emscripten (python/steering-council#256). I absolutely agree that we should finalize PEP 776; but I don't personally consider it a blocker for this PR. |
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…ythonGH-136230) Updates configure script to identify Emscripten as Tier 3. (cherry picked from commit 6ea4258) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
GH-136445 is a backport of this pull request to the 3.14 branch. |
…GH-136230) (#136445) Updates configure script to identify Emscripten as Tier 3. (cherry picked from commit 6ea4258) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
…ython#136230) Updates configure script to identify Emscripten as Tier 3.
…ython#136230) Updates configure script to identify Emscripten as Tier 3.
…ython#136230) Updates configure script to identify Emscripten as Tier 3.
…ython#136230) Updates configure script to identify Emscripten as Tier 3.
…ython#136230) Updates configure script to identify Emscripten as Tier 3.
…arning (pythonGH-136230) (python#136445) Updates configure script to identify Emscripten as Tier 3. (cherry picked from commit 6ea4258) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.