[3.12] gh-125893: Add type check for category argument in warnings.simplefilter and warnings.filterwarning#136303
Closed
hasrat17 wants to merge 2 commits intopython:3.12from
Closed
[3.12] gh-125893: Add type check for category argument in warnings.simplefilter and warnings.filterwarning#136303hasrat17 wants to merge 2 commits intopython:3.12from
hasrat17 wants to merge 2 commits intopython:3.12from
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Thanks for the PR but could you instead create a branch that is checked out from main, make your changes, then open a PR against main instead? we'll take care of backporting the changes to 3.13+ (3.12 won't get fixed as it's security only) |
Contributor
|
Closing since #136305 has been opened against main |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses gh-125893 by adding a type check for the category argument in warnings.simplefilter and warnings.filterwarning,
Previously, warnings.filterwarnings correctly raised an error when the category argument was not a class, but warnings.simplefilter accepted invalid types without raising any error. This inconsistency could lead to confusion and improper warning filtering.
Both warnings.simplefilter and warnings.filterwarning were not raising any warnings while ran with
python -Obut now this is also handled.