Fix SQL statement to calculate updated_at when upserting#1320
Merged
aidanharan merged 1 commit intomainfrom Mar 24, 2025
Merged
Fix SQL statement to calculate updated_at when upserting#1320aidanharan merged 1 commit intomainfrom
updated_at when upserting#1320aidanharan merged 1 commit intomainfrom
Conversation
The previous `CASE` statement used `COALESCE` with `'NULL'` as a fallback value if either `source` or `target` were `NULL`. However, `'NULL'` as written in this statement, is a `varchar` and therefore does not work when comparing with other datatypes. This commit changes the switch statement to check if either both values are equal, or both values are actually `NULL`.
9c40428 to
45bf0ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
CASEstatement usedCOALESCEwith'NULL'as a fallback value if eithersourceortargetwereNULL. However,'NULL'as written in this statement, is avarcharand therefore does not work when comparing with other datatypes (e.g.int).This commit changes the switch statement to check if either both values are equal, or both values are actually
NULL.