Conversation
Member
Author
|
CI failure is because Cutter fails to compile, totally unrelated to the changes made in this PR. I have reproduced it and submitted the fix at rizinorg/cutter#3247. |
3 tasks
This comment was marked as resolved.
This comment was marked as resolved.
wargio
approved these changes
Sep 20, 2023
Member
|
@DMaroo please resend from different branch and new PR. Can't restart all jobs in this one. |
Member
Author
|
Don't I need to update the tests? If I push a new commit with the updated tests, the CI will restart, right? |
Member
That would work too. |
* This way, the `strcmp` check in `SleighIDFromCore` function
results as true, and in the corresponding branch, we extract the
correct architecture using `SleighIdFromSleighAsmConfig`
Member
Author
|
I have restarted the build with an empty commit amend. Many of the test failures previously were unrelated. I will have a look at the new failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, the
strcmpcheck inSleighIDFromCorefunction results as true, and in the corresponding branch, we extract the correct architecture usingSleighIdFromSleighAsmConfig.Before the fix:
After the fix
The above error is architecture and binary agnostic. Fixes https://im.rizin.re/rizinorg/pl/3xiabg1ah3naurrxmoq1ubxqca.