Skip to content

Support optimal confidence from model-eval#2242

Merged
PawelPeczek-Roboflow merged 44 commits intomainfrom
feat/model-eval-recommended-defaults
Apr 22, 2026
Merged

Support optimal confidence from model-eval#2242
PawelPeczek-Roboflow merged 44 commits intomainfrom
feat/model-eval-recommended-defaults

Conversation

@leeclemnet
Copy link
Copy Markdown
Contributor

@leeclemnet leeclemnet commented Apr 17, 2026 •
edited by PawelPeczek-Roboflow
Loading

What does this PR do?

Redo of #2206, which was reverted by #2241.

Includes fixes for bugs found after merging #2206 to main.

Type of Change

  • New feature (non-breaking change that adds functionality)

Testing

  • I have tested this change locally
  • I have added/updated tests for this change

Test details:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation accordingly (if applicable)

Additional Context

@leeclemnet leeclemnet changed the title Feat/model eval recommended defaults Support optimal confidence from model-eval Apr 17, 2026
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch 3 times, most recently from e6ee003 to 08fd135 Compare April 17, 2026 20:56
@leeclemnet leeclemnet marked this pull request as ready for review April 17, 2026 21:17
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch from d7263ee to dea272e Compare April 17, 2026 22:34
@leeclemnet leeclemnet marked this pull request as draft April 17, 2026 22:35
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch 5 times, most recently from bed5679 to c15bf41 Compare April 18, 2026 00:24
@leeclemnet leeclemnet marked this pull request as ready for review April 20, 2026 15:50
@leeclemnet
Copy link
Copy Markdown
Contributor Author

leeclemnet commented Apr 20, 2026

Manual run of post-merge integration tests: https://github.com/roboflow/inference/actions?query=branch%3Afeat%2Fmodel-eval-recommended-defaults
image

@leeclemnet leeclemnet mentioned this pull request Apr 20, 2026
Merged
10 tasks
leeclemnet added 17 commits April 21, 2026 10:48
@leeclemnet
drop pydantic validation on confidence
920cc4f
@leeclemnet
bump version to 0.25.0, update changelog, revert Dockerfile and CI ch…
ff455f5 
…ange
@leeclemnet
bump inference-models requirements to 0.25.0
0de2721
@leeclemnet
fix roboflow-instant-hf scalar confidence path
9c91f46
@leeclemnet
bump inference-models version 0.25.1
2da59b3
@leeclemnet
requirements back to 0.24.4
cee8069
@leeclemnet
tmp: force inference_models source build for dev and integration tests
9c9d6f7
@leeclemnet
add integration tests for per-class pathways
bd15926
@leeclemnet
0.25.1rc1
4c6883e
@leeclemnet
bump inference-models~=0.25.1rc1
0d300b2
@leeclemnet
revert yolov7 IS to keep existing NMS behaviour including objectness col
4a5eba0
@leeclemnet
[tmp] install inference_models from git branch
678bb91
@leeclemnet
0.25.1rc2
da1a228
@leeclemnet
requirements 0.25.1rc2
68c6542
@leeclemnet
try moving yolov8 test to avoid disturbing cache determinism tests
3545a46
@leeclemnet
try removing added yolov8 trt test case
b04a24d
@leeclemnet
0.25.1 for pypi release
99823c1
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch 2 times, most recently from 36cb882 to 99823c1 Compare April 21, 2026 13:23
@PawelPeczek-Roboflow PawelPeczek-Roboflow self-requested a review April 22, 2026 12:36
@leeclemnet
Copy link
Copy Markdown
Contributor Author

leeclemnet commented Apr 22, 2026

merge commits LTGM ✅
can't approve directly as PR author

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit a0ae272 into main Apr 22, 2026
46 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the feat/model-eval-recommended-defaults branch April 22, 2026 12:40
dkosowski87
dkosowski87 reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dkosowski87 dkosowski87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving @PawelPeczek-Roboflow additional commits ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkosowski87 dkosowski87 dkosowski87 left review comments

@PawelPeczek-Roboflow PawelPeczek-Roboflow PawelPeczek-Roboflow approved these changes

@grzegorz-roboflow grzegorz-roboflow Awaiting requested review from grzegorz-roboflow grzegorz-roboflow is a code owner

@hansent hansent Awaiting requested review from hansent hansent is a code owner

@yeldarby yeldarby Awaiting requested review from yeldarby yeldarby is a code owner

@probicheaux probicheaux Awaiting requested review from probicheaux probicheaux is a code owner

@rafel-roboflow rafel-roboflow Awaiting requested review from rafel-roboflow rafel-roboflow is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leeclemnet @dkosowski87 @PawelPeczek-Roboflow