Skip to content

Change stipulated compatibility guarantees.#1073

Draft
fredefox wants to merge 1 commit intorollbar:masterfrom
fredefox:master
Draft

Change stipulated compatibility guarantees.#1073
fredefox wants to merge 1 commit intorollbar:masterfrom
fredefox:master

Conversation

@fredefox
Copy link
Copy Markdown

@fredefox fredefox commented Dec 2, 2021

Change stipulated compatibility guarantees.

I believe the compatibility table is wrong. Taking what it currently says in the readme at face value e.g. rollbar-2.22.1 would support ruby-3.0.2. Which it doesn't.

Type of change

  • Maintenance

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@fredefox fredefox marked this pull request as draft December 2, 2021 10:38
@fredefox
Copy link
Copy Markdown
Author

fredefox commented Dec 2, 2021

I'm realising that my fix is not the correct one either. Feel free to treat this as a bug-report that the compatibility table is wrong. My example in the description still holds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant