Include indent fixes#3080
Open
Omnikron13 wants to merge 28 commits intorust-lang:masterfrom
Open
Conversation
…de_anchored_lines()
take_lines & take_anchored_lines do not require 'include' specified in the name, so for clarity the +'rustdoc_' versions shouldn't either
Author
|
The relevant documentation doesn't need any changes to reflect these changes, though would need an addition if the new behaviour is considered non-obvious. As a side note I ran into unit tests which cover undocumented behaviour while working on this. Anchored includes in the following form aren't covered atm: // ANCHOR: name
println!("included");
// ANCHOR_END: name
println!("not included");
// ANCHOR: name
println!("included");
// ANCHOR_END: name(As an additional detail, there were only actually unit tests for this for the |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Author
|
Note: some of the issues this would fix do so relying on the fact that anything before the include link will be repeated as a prefix (because they are people wanting to use include within block quotes). |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix issues #1626, #1564, #2830, #2521, #1127, #619, #1601.
Would supersede PRs #1718, #2831, #1565, and I think the majority of uses for #1856 & #2333.
There is an open question of what exactly to do with non-whitespace before a link, e.g.foo{{#include ...}}