Add ChapterMutThin for parallel chapter access#3086
Open
SichangHe wants to merge 1 commit intorust-lang:masterfrom
Open
Add ChapterMutThin for parallel chapter access#3086SichangHe wants to merge 1 commit intorust-lang:masterfrom
ChapterMutThin for parallel chapter access#3086SichangHe wants to merge 1 commit intorust-lang:masterfrom
Conversation
SichangHe
force-pushed
the
chapter-mut-thin
branch
from
d7766c4 to
bd8e01e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bookonly allows sequential mutable traversal today, and lacks a way for the much more efficient parallel mutation that would speed up many preprocessed by #cores×.This simple change adds
ChapterMutThinandBook::chapters_mut_thin()to return per-chapter mutable views for parallel access.I've been using this change from my fork
mdbook_fork4lsfor months, withinmdbook-katexandmdbook-header-footer, together w/ Rayon, and haven't had any issues. I think it's a generally useful quality-of-life addition.