migrate convert closure to fn to SyntaxEditor#22204
migrate convert closure to fn to SyntaxEditor#22204Shourya742 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Shourya742
force-pushed
the
2026-04-21-migrate-convert-closure-to-fn
branch
from
3087f3d to
43df39b
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Shourya742
force-pushed
the
2026-04-21-migrate-convert-closure-to-fn
branch
from
43df39b to
47a2813
Compare
|
I see that this PR changes the assist logic considerably. I don't like that and it makes the review harder. Why did you do that? |
|
☔ The latest upstream changes (possibly #22131) made this pull request unmergeable. Please resolve the merge conflicts. |
Hmmm... I was trying to replace the range-based edits with the editor. Now, reflecting on your comment, it seems this makes it difficult to review. Let me revert those changes then and make only ted based removal changes... |
3 participants
This PR migrates the convert_closure_to_fn assist to SyntaxEditor.
part of #15710 and #18285