Skip to content

Add wrap in tree list with editor#22256

Open
Shourya742 wants to merge 2 commits intorust-lang:masterfrom
Shourya742:2026-05-03-add-wrap-in-tree-list-with-editor
Open

Add wrap in tree list with editor#22256
Shourya742 wants to merge 2 commits intorust-lang:masterfrom
Shourya742:2026-05-03-add-wrap-in-tree-list-with-editor

Conversation

@Shourya742
Copy link
Copy Markdown
Member

part of #15710 and #18285

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2026
@Shourya742 Shourya742 force-pushed the 2026-05-03-add-wrap-in-tree-list-with-editor branch from 800c11d to 9af2150 Compare May 3, 2026 05:07
@Shourya742 Shourya742 force-pushed the 2026-05-03-add-wrap-in-tree-list-with-editor branch from 9af2150 to 27afa8a Compare May 3, 2026 05:10
Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function isn't compatible with giving nodes lifetimes. So I'm fine with merging this as-is, but we'll have to change it eventually.

View changes since this review

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

Do you want me to merge this or work on what I said?

@Shourya742
Copy link
Copy Markdown
Member Author

Do you want me to merge this or work on what I said?

All these methods, assists, completions, and others that depend on tree-structure edits are strongly tied to the idea of in-place edits. I initially wanted to approach this differently, but that would require significant changes to insert_use and more cognitive burder to reviewer. I am still working toward a more holistic understanding of how to better handle such cases. I am fine with merging this for now, and simultaneously gaining a clearer overview of where we have similar patterns defined and tackling them together.

@Shourya742
Copy link
Copy Markdown
Member Author

@ChayimFriedman2 can we get this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants