internal: Do not drop ExpansionSpanMap and AstIdMap asynchronously#22258
Open
ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
Open
internal: Do not drop ExpansionSpanMap and AstIdMap asynchronously#22258ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
ExpansionSpanMap and AstIdMap asynchronously#22258ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
Conversation
They do not contain things that require looping when dropping, only `Vec`/`Arena`/`HashTable` of non-`Drop` types. Therefore sending to an external channel is likely to be slower than just dropping.
rustbot
added
the
S-waiting-on-review
Member
|
What do you mean with looping? The idea behind this was that salsa cancellation was blocking for a fair bit at times due to the amount of data dropped here, as these are used as LRU'd query results |
Contributor
Author
|
What I mean is, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They do not contain things that require looping when dropping, only
Vec/Arena/HashTableof non-Droptypes. Therefore sending to an external channel is likely to be slower than just dropping.r? Veykril