Test graviola in CI#1631
Conversation
CathalMullan
force-pushed
the
graviola-tests
branch
2 times, most recently
from
fe82b78 to
6b54626
Compare
CathalMullan
force-pushed
the
graviola-tests
branch
3 times, most recently
from
40ea033 to
914eb80
Compare
|
Opted to patch out crabgrind to avoid needing valgrind in CI. |
| serde_json = "1" | ||
| - | ||
| -[target.'cfg(all(target_os = "linux", target_arch = "x86_64"))'.dev-dependencies] | ||
| -crabgrind = "=0.1.9" # compatible with valgrind package on GHA ubuntu-latest |
There was a problem hiding this comment.
Do you think upstream would accept putting crabgrind behind a default-on feature? And doing the aws-lc-rs update upstream? That would reduce the maintenance burden of keeping this patch up to date.
There was a problem hiding this comment.
I imagine they'd be fine with moving it behind a feature, I'll reach out and see.
There was a problem hiding this comment.
This has been handled by ctz/graviola#174, now behind the __ctgrind feature.
CathalMullan
force-pushed
the
graviola-tests
branch
from
914eb80 to
fe90371
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
3 participants
Opening as a draft for now, since none of these jobs will actually pass:
x86_64 needs the rustc fixvalgrind is needed due to crabgrind usage: https://github.com/ctz/graviola/blob/v/0.3.2/graviola/src/low/ct.rs#L5
Could consider patching it out, or making it optional upstream.