Fix compilation for custom JSON targets#1638
Merged
bjorn3 merged 1 commit intorust-lang:mainfrom Apr 10, 2026
Merged
Conversation
This allows custom JSON targets to compile, as the assembler was previously failing with an error that `-Zunstable-options` had not been set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple change to allow compilation with custom JSON targets. Previously the Cranelift backend (and not LLVM) would produce an error as the
rustcassembler process expected-Zunstable-optionswhen JSON targets were used.Skipped doing fancier logic as always passing
-Zunstable-optionsseems to work fine, but could be wrong! Happy to change things if I'm wrong about how that works :)