fix(alias): validate endpoint URLs before saving#183
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces shared validation for alias endpoints so rc alias set rejects invalid S3 service URLs (notably RustFS volume expansion patterns) before persisting them, preventing later runtime/network failures.
Changes:
- Added
validate_alias_endpointtorc-coreand re-exported it publicly. - Reused shared HTTP(S)+host validation for env-based aliases and CLI input.
- Added unit tests in
rc-coreand CLI tests ensuring invalid endpoints are rejected with a usage error.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/core/src/lib.rs | Re-exports the new shared endpoint validation API from rc-core. |
| crates/core/src/alias.rs | Adds validate_alias_endpoint, factors out HTTP(S)+host validation, and adds tests. |
| crates/cli/src/commands/alias.rs | Validates endpoints in alias set before saving; adds CLI test for invalid endpoint rejection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #181
Background
Issue #181 reports configuring an alias with
http://rustfs-node{1...32}:9000, then seeingrc ls rustfsfail withNetwork error: dispatch failure.That endpoint is RustFS server volume expansion syntax, not a single S3 service endpoint.
rc alias setonly rejected empty endpoints, so the invalid endpoint could be saved and fail later during the S3 request.Solution
rc-core.rc alias setwhen the endpoint is invalid.Tests
cargo test -p rc-core validate_alias_endpoint --libcargo test -p rustfs-cli commands::alias::tests --libRC_CONFIG_DIR=<tmp> cargo run -q -p rustfs-cli -- alias set rustfs 'http://rustfs-node{1...32}:9000' xxx xxxreturns exit code 2make pre-commit