refactor: Move the file-api models to multi-versioned interface#1273
Open
LecrisUT wants to merge 18 commits intoscikit-build:mainfrom
Open
refactor: Move the file-api models to multi-versioned interface#1273LecrisUT wants to merge 18 commits intoscikit-build:mainfrom
LecrisUT wants to merge 18 commits intoscikit-build:mainfrom
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
force-pushed
the
refactor/file-api-convert-all
branch
from
97aaa8e to
c901f37
Compare
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
force-pushed
the
refactor/file-api-convert-all
branch
from
c901f37 to
d9d5199
Compare
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
force-pushed
the
refactor/file-api-convert-all
branch
from
d9d5199 to
ecd624f
Compare
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
force-pushed
the
refactor/file-api-convert-all
branch
from
ecd624f to
b1b345e
Compare
LecrisUT
commented
Apr 30, 2026
Comment on lines
+59
to
+74
| @dataclasses.dataclass(frozen=True) | ||
| class Compiler_1_1(Compiler_1_0): | ||
| """ | ||
| ..versionadded:: 4.3.0 | ||
| """ | ||
|
|
||
| commandFragment: Optional[str] = None | ||
|
|
||
|
|
||
| @dataclasses.dataclass(frozen=True) | ||
| class Toolchain_1_1(Toolchain_1_0): | ||
| """ | ||
| ..versionadded:: 4.3.0 | ||
| """ | ||
|
|
||
| compiler: Compiler_1_1 |
Collaborator
Author
There was a problem hiding this comment.
Looking at the format here with fresh eyes, this looks much less navigable then grouping them together. Afaik the fields are all additive in the same major although that is not stated as being a guarantee.
The main good thing here is the documentation of the fields and what version of the object kind and cmake version they are introduced.
@henryiii what are your thoughts? I am considering scrapping this approach and do only the documentation, making sure the object kind/version is easily introspected, and generalizing the loading of indirect objects (from jsonFile or equivalents)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codemodelconfigureLogcachecmakeFilestoolchainsDepends-on: #1012