Conversation
|
@LecrisUT Any thoughts as to why just the one fedora test might be failing here? It's on the new code, so it looks valid. |
|
Oh interesting. The only difference that should be there are the compilers. I'll need to dig into the code changes. Btw $ tmt run -a \
provision --how=container --image=fedora:rawhide \
plans --name=/tests/plans/pytest \
login -t |
|
Ok, I am reproducing locally. My suspicion is that |
|
Oops, wrong finding previously:
see the |
There was a problem hiding this comment.
Pull request overview
Adds initial support and test coverage for building editable wheels via the Hatchling hook integration, extending scikit-build-core’s Hatch plugin to handle PEP 660-style editable outputs (redirect/inplace) and validating resulting wheel metadata and contents.
Changes:
- Extend
ScikitBuildHook(Hatch plugin) to supportversion="editable"builds, including redirect/inplace modes and correctpure_python/WHEEL metadata handling. - Refactor editable-wheel file generation into reusable helpers (
editable_redirect_files,editable_inplace_files,get_packages) and reuse them in the PEP 517 wheel builder. - Add Hatchling-focused tests (editable wheel build + editable install) and adjust the Hatchling test package CMakeLists to support editable inplace output paths.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_hatchling.py |
Adds assertions for wheel Root-Is-Purelib, plus new editable wheel and editable install integration tests for Hatchling hook behavior. |
tests/packages/hatchling/cpp/CMakeLists.txt |
Ensures editable inplace builds place built extension outputs in the expected source-package directory, including multi-config generator handling. |
src/scikit_build_core/hatch/plugin.py |
Implements Hatchling editable wheel support (redirect/inplace), updates config/state handling, and sets correct pure_python behavior. |
src/scikit_build_core/build/wheel.py |
Refactors editable wheel generation to use new helper functions and shared package discovery. |
src/scikit_build_core/build/_editable.py |
Introduces helper functions for generating editable wheel files and package discovery to share logic across builders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Assisted-by: Copilot:GPT-5.4
Assisted-by: Copilot:GPT-5.4-mini
Assisted-by: Copilot:GPT-5.4 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
e495e20 to
2a67c41
Compare
Editable support for the hatchling plugin.
🤖 Assisted-by: Copilot:GPT-5.4