Open
Conversation
manbearshark
commented
May 14, 2017
| return ({ result }); | ||
| } catch (error) { | ||
| return ({ error }); | ||
| } |
Author
There was a problem hiding this comment.
Return either a result or error key depending on the API call outcome.,
manbearshark
commented
May 14, 2017
| describe('callApi', () => { | ||
| it('handles 400 error with an exception', async () => { | ||
| const url = 'http://fakeurl'; | ||
| fetch.mockResponseOnce(JSON.stringify([{description: "add a todo"}]), {status: 400}); |
Author
There was a problem hiding this comment.
Added fetch-mock to test the API stuff.
manbearshark
commented
May 14, 2017
| yield put(todosActions.addTodoSuccess(normalizeObjectToMap(response))); | ||
| } catch (e) { | ||
| yield put(todosActions.addTodoError()); | ||
| export function* raceCallApi({ |
Author
There was a problem hiding this comment.
Generator used to handle all apiCall cases in the sagas.
manbearshark
commented
May 14, 2017
|
|
||
| const action = todosActions.toggleTodo(payload); | ||
| const generator = sagas.toggleTodo(action); | ||
| fetch.mockResponseOnce(JSON.stringify([{description: "add a todo"}]), delay); |
Author
There was a problem hiding this comment.
Pretty cool that fetch-mock can handle testing timeout use cases.
manbearshark
commented
May 14, 2017
| @@ -0,0 +1 @@ | |||
| global.fetch = require('jest-fetch-mock'); | |||
Author
There was a problem hiding this comment.
This is required to test using fetch-mock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some issues with how sagas handled exceptions - this has been moved to the API code. Also I added a common generator function the sagas can use to handle todo actions, which reduces code duplication. Also added some tests for the async API stuff and the new saga generator functions.
This change is