Fix CI lint offenses and SSR ActionCable loading

Author: justin808

client/app/bundles/comments/components/CommentBox/CommentBox.jsx

@@ -2,7 +2,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import Immutable from 'immutable';
 import _ from 'lodash';
-import * as ActionCable from '@rails/actioncable';
 import { injectIntl } from 'react-intl';
 import BaseComponent from 'libs/components/BaseComponent';
 import actionCableUrl from 'libs/actionCableUrl';
@@ -36,6 +35,11 @@ class CommentBox extends BaseComponent {
 
   subscribeChannel() {
     const { messageReceived } = this.props.actions;
+
+    // Avoid loading ActionCable during server-side rendering.
+    // eslint-disable-next-line global-require
+    const actionCableModule = require('@rails/actioncable');
+    const ActionCable = actionCableModule.default || actionCableModule;
     this.cable = ActionCable.createConsumer(actionCableUrl());
 
     /* eslint no-console: ["error", { allow: ["log"] }] */
@@ -62,7 +66,7 @@ class CommentBox extends BaseComponent {
   }
 
   componentWillUnmount() {
-    this.cable.subscriptions.remove({ channel: 'CommentsChannel' });
+    this.cable?.subscriptions.remove({ channel: 'CommentsChannel' });
   }
 
   refreshComments() {

config/ci.rb

@@ -9,9 +9,9 @@ module TutorialCI
       "Build: Test assets",
       "RAILS_ENV=test bin/conductor-exec bin/rails react_on_rails:generate_packs && " \
       "bin/conductor-exec yarn res:build && " \
-      "bin/conductor-exec yarn build:test",
+      "bin/conductor-exec yarn build:test"
     ],
     ["Tests: RSpec", "bin/conductor-exec bin/rspec"],
-    ["Tests: Jest", "bin/conductor-exec yarn test:client"],
+    ["Tests: Jest", "bin/conductor-exec yarn test:client"]
   ].freeze
 end

config/environments/production.rb

@@ -93,7 +93,7 @@
   # config.host_authorization = { exclude: ->(request) { request.path == "/up" } }
 
   # Action Cable endpoint configuration
-  production_host = ENV["PRODUCTION_HOST"]
+  production_host = ENV.fetch("PRODUCTION_HOST", nil)
   if production_host.present?
     config.action_cable.url = "wss://#{production_host}/cable"
     config.action_cable.allowed_request_origins = ["https://#{production_host}"]