Fix(cli): Rename adb-client command to adb-tunnel for consistency#283
Merged
shamanec merged 1 commit intoshamanec:developfrom Apr 16, 2026
Merged
Conversation
The CLI command was registered as 'adb-client' but the rest of the codebase and docs used 'adb-tunnel': - HTTP endpoints: /device/:udid/adb-tunnel and /devices/control/:udid/adb-tunnel - Router files: hub/router/adb_tunnel.go, provider/router/adb_tunnel.go - Handler functions: ADBTunnelHandler, ADBTunnelProxy - Usage examples in docs/adb-client.md referenced './GADS adb-tunnel' Running './GADS adb-tunnel' as documented failed with 'unknown command "adb-tunnel"'. Align the Cobra command, variable name, docs filename, and links with the rest of the tunnel naming so the documented usage actually works. - main.go: Use 'adb-tunnel', rename adbClientCmd to adbTunnelCmd - Rename docs/adb-client.md to docs/adb-tunnel.md - Update README.md and docs/hub.md links
shamanec
approved these changes
Apr 16, 2026
Owner
|
Reasonable 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Cobra subcommand was registered as
adb-client, but the rest of the codebase consistently usesadb-tunnel:/device/:udid/adb-tunnel,/devices/control/:udid/adb-tunnelhub/router/adb_tunnel.go,provider/router/adb_tunnel.goADBTunnelHandler,ADBTunnelProxydocs/adb-client.mdalready referenced./GADS adb-tunnelAs a result, following the docs literally fails:
Changes
main.go: rename Cobra commandadb-client→adb-tunneland variableadbClientCmd→adbTunnelCmddocs/adb-client.md→docs/adb-tunnel.md(git rename, history preserved)README.mdanddocs/hub.mdNo behavior changes — only renames. The documented usage now actually works.
Test plan
go buildsucceeds./GADS adb-tunnel --helpshows the command./GADS adb-clientcorrectly errors with "unknown command"adb-client/adbClientreferences removed (verified via grep)