Remove unnecessary provide methode of PokedexClient#73
Open
houssem85 wants to merge 2 commits intoskydoves:mainfrom
Open
Remove unnecessary provide methode of PokedexClient#73houssem85 wants to merge 2 commits intoskydoves:mainfrom
houssem85 wants to merge 2 commits intoskydoves:mainfrom
Conversation
|
@houssem85 There are conflicts in your code. I don't think huge changes even if they are just refactoring should be proposed in one go. You can create multiple PRs. It becomes more easier for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Remove unnecessary provide methode of PokedexClient in hilt NetworkModule because this class is not a third party class, his constructor annotated with @Inject define how to instantiate it.
This is my first contribution in open source projects, eagerly waiting for your evaluation.