Conversation
There was a problem hiding this comment.
Includes should not be moved past defines.
There was a problem hiding this comment.
We need to make it not break aligned numbers like this.
There was a problem hiding this comment.
right I will try to see if I can make it do that
There was a problem hiding this comment.
- and / should not be wrapped in spaces (but + and - should be wrapped in spaces) to improve readability.
There was a problem hiding this comment.
uhm ok sounds like a good idea
There was a problem hiding this comment.
clang format does unfortunately not seem to support this (?)
is this a deal breaker? It seems to want to have spaces between most operators.
There was a problem hiding this comment.
Don't auto word wrap long lines.
There was a problem hiding this comment.
- if/while should not have spaces between "("
- if statements without {} should always be on the same line as their statement (it prevents bugs)
There was a problem hiding this comment.
do we always want {} to create a new line?
There was a problem hiding this comment.
No, leave it up to the programmer to put the new lines if they want it.
There was a problem hiding this comment.
doesn't seem to be an option sadly
There was a problem hiding this comment.
Where did this extra semicolon come from?
There was a problem hiding this comment.
Can you configure the formatting to not touch the location of * in variable names?
There was a problem hiding this comment.
dunno but I will try
There was a problem hiding this comment.
No sadly, it does not seem like it, but we can tell it to put pointers to the left, right or in the middle. Maybe I simply missed it in the docs because it does feel like it should be an option but it is not.
There was a problem hiding this comment.
Does it still format them even if you don't have a PointerAlignment field?
There was a problem hiding this comment.
I can look into it.
There was a problem hiding this comment.
Nope it defaults to right alignment if I do that.
There was a problem hiding this comment.
It needs to not break up these case labels and the returns onto separate lines.
They are laid out like this to allow block edits.
hazelwiss
force-pushed
the
formatting
branch
from
184ddd6 to
859c1e1
Compare
hazelwiss
force-pushed
the
formatting
branch
from
242f3d9 to
81fb1ed
Compare
| "Toggle Full Screen" | ||
| }; | ||
| const static char *se_keybind_names[SE_NUM_KEYBINDS] = { | ||
| "A", |
There was a problem hiding this comment.
This should only be 2 spaces
There was a problem hiding this comment.
we want a tab width of 2 spaces?
| // Utilize a watchdog channel to detect if the audio context has encountered an error | ||
| // and restart it if a problem occurred. | ||
| int audio_watchdog_timer; | ||
| int audio_watchdog_triggered; |
There was a problem hiding this comment.
The spacing is long in order to have alignment, we could add newlines between the lines to alleviate that
There was a problem hiding this comment.
things like this may happen a bit everywhere though so declarations are aligned, it is sadly impossible as far as I can see to give it a sort of threshold.
hazelwiss
force-pushed
the
formatting
branch
from
a3c27a8 to
0b70c63
Compare
3 participants
Added a formatting script to format the project, and crated a clang-format script using the LLVM formatting style. If we want another style it is a simple fix!