Skip to content

perf: pre-declare position on footnote factories #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristianMurphy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: pre-declare position on footnote factories #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,13 @@ function enterFootnoteCallString() {
* @type {FromMarkdownHandle}
*/
function enterFootnoteCall(token) {
this.enter({type: 'footnoteReference', identifier: '', label: ''}, token)
// Trailing `position: undefined` keeps the footnoteReference hidden class
// stable; mdast-util-from-markdown's enter() patches the field to a real
// value but the property already exists, so no shape transition fires.
this.enter(
{type: 'footnoteReference', identifier: '', label: '', position: undefined},
token
)
}

/**
Expand All @@ -47,8 +53,16 @@ function enterFootnoteDefinitionLabelString() {
* @type {FromMarkdownHandle}
*/
function enterFootnoteDefinition(token) {
// See enterFootnoteCall above for the rationale on the trailing
// position field.
this.enter(
{type: 'footnoteDefinition', identifier: '', label: '', children: []},
{
type: 'footnoteDefinition',
identifier: '',
label: '',
children: [],
position: undefined
},
token
)
}
Expand Down
Loading