Skip to content

perf: pre-declare position on table factories #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristianMurphy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: pre-declare position on table factories #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
187d4d3
chore: drop now-unused @ts-expect-error directives in serializeData
ChristianMurphy May 4, 2026
304192b
perf: pre-declare position on table factories
ChristianMurphy May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,17 @@ export function gfmTableFromMarkdown() {
function enterTable(token) {
const align = token._align
assert(align, 'expected `_align` on table')
// Trailing `position: undefined` keeps the table hidden class stable;
// mdast-util-from-markdown's enter() patches the field to a real value
// but the property already exists, so no shape transition fires.
this.enter(
{
type: 'table',
align: align.map(function (d) {
return d === 'none' ? null : d
}),
children: []
children: [],
position: undefined
},
token
)
Expand All @@ -92,7 +96,8 @@ function exitTable(token) {
* @type {FromMarkdownHandle}
*/
function enterRow(token) {
this.enter({type: 'tableRow', children: []}, token)
// See enterTable above for the rationale on the trailing position field.
this.enter({type: 'tableRow', children: [], position: undefined}, token)
}

/**
Expand All @@ -108,7 +113,8 @@ function exit(token) {
* @type {FromMarkdownHandle}
*/
function enterCell(token) {
this.enter({type: 'tableCell', children: []}, token)
// See enterTable above for the rationale on the trailing position field.
this.enter({type: 'tableCell', children: [], position: undefined}, token)
}

// Overwrite the default code text data handler to unescape escaped pipes when
Expand Down Expand Up @@ -230,11 +236,8 @@ export function gfmTableToMarkdown(options) {
function serializeData(matrix, align) {
return markdownTable(matrix, {
align,
// @ts-expect-error: `markdown-table` types should support `null`.
alignDelimiters,
// @ts-expect-error: `markdown-table` types should support `null`.
padding,
// @ts-expect-error: `markdown-table` types should support `null`.
stringLength
})
}
Expand Down
Loading