encode less-than signs in text context after whitespace#71
Closed
pjjw wants to merge 1 commit intosyntax-tree:mainfrom
Closed
encode less-than signs in text context after whitespace#71pjjw wants to merge 1 commit intosyntax-tree:mainfrom
pjjw wants to merge 1 commit intosyntax-tree:mainfrom
Conversation
Member
|
Hi! |
Author
|
sorry, got distracted for a bit and then went on vacation. let me come up with a better example in the next day or two |
Author
|
ok, yeah, this is 100% on me- i walked back docusaurus choking on something to this admittedly weird workaround because i didn't notice that docusaurus was parsing something as MDX, not commonmark. nevermind, thanks for the attention, and sorry for the misfile. |
|
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
I found a case using remark-cli/remark-lint/remark-stringify where a bare
<was getting emitted as markdown when inside of a list and causing rendering problems. This adds a test case to this and adds a definition in unsafe.js to prevent this from happening.I'm not sure this is the minimal set of unsafe conditions- it does seem to catch my case and not some other cases where a new escape would be annoying, but I haven't really been exhaustive in searching, relying mostly on the existing test suite.